better assert

getsentry · Jul 4, 2024 · 9e78dee · 9e78dee
1 parent f8a5f11
commit 9e78dee
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -1160,11 +1160,9 @@ jobs:
           - false
         include:
           - test-application: 'create-remix-app'
-            build-command: 'test:build-sourcemaps'
             assert-command: 'test:assert-sourcemaps'
             label: 'create-remix-app (sourcemaps)'
           - test-application: 'create-remix-app-legacy'
-            build-command: 'test:build-sourcemaps'
             assert-command: 'test:assert-sourcemaps'
             label: 'create-remix-app-legacy (sourcemaps)'
 

diff --git a/dev-packages/e2e-tests/test-applications/create-remix-app-legacy/package.json b/dev-packages/e2e-tests/test-applications/create-remix-app-legacy/package.json
@@ -9,9 +9,8 @@
     "typecheck": "tsc",
     "clean": "npx rimraf node_modules pnpm-lock.yaml",
     "test:build": "pnpm install && npx playwright install && pnpm build",
-    "test:build-sourcemaps": "pnpm install && npx playwright install && pnpm build && pnpm upload-sourcemaps",
     "test:assert": "pnpm playwright test",
-      "test:assert-sourcemaps": "pnpm -v"
+    "test:assert-sourcemaps": "pnpm upload-sourcemaps"
   },
   "dependencies": {
     "@sentry/remix": "latest || *",

diff --git a/dev-packages/e2e-tests/test-applications/create-remix-app/package.json b/dev-packages/e2e-tests/test-applications/create-remix-app/package.json
@@ -9,9 +9,8 @@
     "typecheck": "tsc",
     "clean": "npx rimraf node_modules pnpm-lock.yaml",
     "test:build": "pnpm install && npx playwright install && pnpm build",
-    "test:build-sourcemaps": "pnpm install && npx playwright install && pnpm build && pnpm upload-sourcemaps",
     "test:assert": "pnpm playwright test",
-    "test:assert-sourcemaps": "pnpm -v"
+    "test:assert-sourcemaps": "pnpm upload-sourcemaps"
   },
   "dependencies": {
     "@sentry/remix": "latest || *",