Skip to content

Commit

Permalink
test(remix): Add dependency resolution overrides to fix breaking Node…
Browse files Browse the repository at this point in the history
… compatibility changes in dependencies (#12793)

This PR fixes our broken Remix v1 @ Node 16 integration test. Over the
weekend, the following transitive dependencies received minor and patch
releases which removed support for EOL Node versions.

- `glob` (isaacs/node-glob#596)
- `lru-cache` (isaacs/node-lru-cache#340)
- `jackspeack` (isaacs/jackspeak#13)

IMO this, despite the dropped versions being EOL, is a breaking change
and a major inconvenience for a lot of users. I added comments/opened
issues with the request to revert the Node version drops and do it in a
major version instead. We're by far not the only affected ones. As our
tests show, at least everyone using Remix@1 on Node 16 will be broken by
this.

To fix, I added dependency resolutions, mostly scoped to specific
packages that depend on one of the three packages. Global overrides for
`glob` and `lru-cache` did not work because we have multiple
dependencies depending on different major versions of said packages.
  • Loading branch information
Lms24 authored Jul 8, 2024
1 parent ecc95e7 commit d6cd5ca
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion packages/remix/test/integration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@
"@sentry/utils": "file:../../../utils",
"@vanilla-extract/css": "1.13.0",
"@vanilla-extract/integration": "6.2.4",
"@types/mime": "^3.0.0"
"@types/mime": "^3.0.0",
"@sentry/remix/glob": "<10.4.3",
"jackspeak": "<3.4.1",
"**/path-scurry/lru-cache": "10.2.0"
},
"engines": {
"node": ">=14.18"
Expand Down

0 comments on commit d6cd5ca

Please sign in to comment.