Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): Update Rollup to v4 #11087

Merged
merged 7 commits into from
Mar 14, 2024
Merged

feat(build): Update Rollup to v4 #11087

merged 7 commits into from
Mar 14, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 13, 2024

This PR updates Rollup to v4 and updates all the plugins to their latest versions.

When testing bundling of the new otel powered Node SDK, there are runtime errors caused by ESM/CJS interoperability. There have been plenty of issues fixed around this in both Rollup and the CommonJs plugin so we need to update.

The changelog doesn't do justice for how much of a pain this was.

Future work that came out of this pain:

@timfish timfish changed the title feat(build): Rollup 4 feat(build): Update Rollup to v4 Mar 13, 2024
@timfish timfish marked this pull request as ready for review March 13, 2024 23:42
@timfish timfish requested a review from AbhiPrasad March 13, 2024 23:42
@AbhiPrasad AbhiPrasad requested review from lforst, Lms24 and mydea March 14, 2024 03:34
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim!

(I wonder if this changes anything w.r.t the weirdness around export * from @sentry/node re-exports not working as expected in higher level packages)

@timfish
Copy link
Collaborator Author

timfish commented Mar 14, 2024

I wonder if this changes anything w.r.t the weirdness around export * from @sentry/node re-exports not working as expected in higher level packages

This PR primarily affects bundling or importing of CJS dependencies which might impact higher level SDKs.

The @sentry/node CJS and ESM output is virtually unchanged by this PR.

Do you have some examples of where this has been an issue?

@AbhiPrasad AbhiPrasad merged commit 7054190 into develop Mar 14, 2024
91 checks passed
@AbhiPrasad AbhiPrasad deleted the timfish/rollup-4 branch March 14, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants