-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): Update Rollup to v4 #11087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tim!
(I wonder if this changes anything w.r.t the weirdness around export * from @sentry/node
re-exports not working as expected in higher level packages)
This PR primarily affects bundling or importing of CJS dependencies which might impact higher level SDKs. The Do you have some examples of where this has been an issue? |
…ript into timfish/rollup-4
This PR updates Rollup to v4 and updates all the plugins to their latest versions.
When testing bundling of the new otel powered Node SDK, there are runtime errors caused by ESM/CJS interoperability. There have been plenty of issues fixed around this in both Rollup and the CommonJs plugin so we need to update.
The changelog doesn't do justice for how much of a pain this was.
Future work that came out of this pain: