test: Port onerror tests to playwright #11666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
Lms24 and
s1gr1d
and removed request for
a team
mydea
approved these changes
Apr 18, 2024
Lms24
approved these changes
Apr 18, 2024
...s/browser-integration-tests/suites/public-api/instrumentation/onError/non-string-arg/test.ts
Outdated
Show resolved
Hide resolved
|
General comment; not blocking this PR: Long-term, I'd like us to move away from these kinds of workarounds where we simulate something that rather than doing it more "naturally". This behaviour doesn't resemble how errors would actually be thrown a real-life project. Because of the "Script Error" limitation we have very few tests where we just throw errors naturally. To be fair, calling I opened #11678 to track this more broadly. |
…umentation/onError/non-string-arg/test.ts Co-authored-by: Lukas Stracke <[email protected]>
size-limit report 📦
|
AbhiPrasad
added a commit
that referenced
this pull request
Apr 24, 2024
ref #11084 This test ports `packages/browser/test/integration/suites/onunhandledrejection.js` playwright. Because of the same limitations as outlined with the on error tests #11666, I had to use calls to `window.onunhandledrejection` to simulate these tests instead of just using `Promise.reject` to test the handler. #11678 tracks being able to fix this so we can avoid directly calling `window.onunhandledrejection` to test. As `onunhandledrejection.js` was the last suite to use the old integration tests, I fully removed that code and the corresponding GH action workflow. I also removed the monorepo deps on `karma`, `chai` and `sinon`. Extremely satisfying.
AbhiPrasad
pushed a commit
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying #11543 again.
This ports
packages/browser/test/integration/suites/onerror.jsto playwright. Because I couldn't throw top level errors without generating script errors, I elected to simulatewindow.onerrorbeing called.ref #11084