test: Fix e2e test race condition by buffering events #12739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Jul 3, 2024
| @@ -247,49 +282,54 @@ export async function waitForPlainRequest( | |||
| /** Wait for a request to be sent. */ | |||
| export async function waitForRequest( | |||
| proxyServerName: string, | |||
| timestamp: number, | |||
There was a problem hiding this comment.
m: Can we make this optional, as third argument, and just default to Date.now()? I guess we'll want this like this basically always? 😅 (same for the other methods)
mydea
reviewed
Jul 4, 2024
Co-authored-by: Francesco Novy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes e2e tests less flakey by adding an event buffer that is used to send events to callback listeners that have not managed to connect in time for a particular events.
We do this by letting the event listeners also send along a timestamp from which point onwards they would like to receive events.
The race condition would have happened when a listener is registered and an event is triggered right after, meaning the event would escape the provided callback because the listener hasn't connected yet. Slim chance but happens.
We will consume more memory by buffering but it is hopefully managable. GH runners are free right?