Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix permissions for external contributors PRs (for real?) #12776

Merged
merged 2 commits into from
Jul 5, 2024
Merged

ci: Fix permissions for external contributors PRs (for real?) #12776

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfd7092
ci: Fix permissions for external contributors PRs
mydea Jul 5, 2024
e94c229
Only run when merged
mydea Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/external-contributors.yml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed we should check the pr status for when it is merged, not just closed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a check for this 👍

Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
jobs:
external_contributor:
name: External Contributors
permissions:
pull-requests: write
contents: write
runs-on: ubuntu-20.04
if: |
github.event.pull_request.author_association != 'COLLABORATOR'
Expand Down
Loading