Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(nestjs): Move setupNestErrorHandler method from @sentry/node to @sentry/nestjs #12829

Closed
wants to merge 4 commits into from
Closed

chore(nestjs): Move setupNestErrorHandler method from @sentry/node to @sentry/nestjs #12829

wants to merge 4 commits into from

Conversation

nicohrubec
Copy link
Contributor

Just a little refactor.

mydea
mydea requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do that (sadly) because this would break existing users using this in @sentry/node :O

IMHO we can possibly leave the "old" implementation there, but add a new/better implementation (with types etc) in the nestjs package? 🤔

@nicohrubec
Copy link
Contributor Author

nicohrubec commented Jul 9, 2024 •
edited
Loading

@mydea Yes sorry, you are right, thanks for the hint. Will close this

@nicohrubec nicohrubec closed this Jul 9, 2024
@nicohrubec nicohrubec deleted the nh/move-nest-error-handler branch July 9, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicohrubec @mydea