Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(typescript): Remove dom types from main tsconfig #12836

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

AbhiPrasad
Copy link
Member

Remove dom types from packages/typescript/tsconfig.json and add it to the respective packages that need them.

This is important because we should only be adding dom types to packages that will be used in the browser.

unblocks #12733

@AbhiPrasad AbhiPrasad requested a review from a team July 9, 2024 16:56
@AbhiPrasad AbhiPrasad self-assigned this Jul 9, 2024
@AbhiPrasad AbhiPrasad requested review from chargome, andreiborza and mydea and removed request for a team July 9, 2024 16:56
Copy link
Contributor

github-actions bot commented Jul 9, 2024

size-limit report 📦

Path Size
@sentry/browser 22.31 KB (0%)
@sentry/browser (incl. Tracing) 33.45 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) 69.2 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.53 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.27 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.9 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.76 KB (+0.01% 🔺)
@sentry/browser (incl. metrics) 26.59 KB (-0.01% 🔽)
@sentry/browser (incl. Feedback) 38.98 KB (0%)
@sentry/browser (incl. sendFeedback) 26.92 KB (-0.01% 🔽)
@sentry/browser (incl. FeedbackAsync) 31.54 KB (0%)
@sentry/react 25.05 KB (0%)
@sentry/react (incl. Tracing) 36.49 KB (0%)
@sentry/vue 26.41 KB (0%)
@sentry/vue (incl. Tracing) 35.31 KB (+0.01% 🔺)
@sentry/svelte 22.44 KB (-0.01% 🔽)
CDN Bundle 23.52 KB (0%)
CDN Bundle (incl. Tracing) 35.21 KB (0%)
CDN Bundle (incl. Tracing, Replay) 69.31 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.51 KB (+0.01% 🔺)
CDN Bundle - uncompressed 69.02 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 104.04 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.43 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 227.15 KB (0%)
@sentry/nextjs (client) 36.37 KB (0%)
@sentry/sveltekit (client) 34.1 KB (+0.01% 🔺)
@sentry/node 130.81 KB (+0.01% 🔺)
@sentry/node - without tracing 91.89 KB (+0.02% 🔺)
@sentry/aws-serverless 117.06 KB (+0.01% 🔺)

@AbhiPrasad AbhiPrasad force-pushed the abhi-remove-dom-tsconfig branch from 4cfa8ff to 85eae4e Compare July 9, 2024 17:05
@AbhiPrasad AbhiPrasad requested a review from a team as a code owner July 9, 2024 17:05
@AbhiPrasad AbhiPrasad force-pushed the abhi-remove-dom-tsconfig branch from 85eae4e to ed48aa4 Compare July 9, 2024 20:30
@AbhiPrasad AbhiPrasad changed the title build: Remove dom types from main tsconfig ref(typescript): Remove dom types from main tsconfig Jul 9, 2024
@AbhiPrasad AbhiPrasad force-pushed the abhi-remove-dom-tsconfig branch from ed48aa4 to 81b0341 Compare July 9, 2024 22:06
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) July 10, 2024 13:41
@AbhiPrasad AbhiPrasad merged commit 3ad3bdd into develop Jul 10, 2024
121 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-remove-dom-tsconfig branch July 10, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants