test(nextjs): Fix canary tests #12875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Jul 11, 2024
| @@ -39,7 +39,10 @@ test('Creates a navigation transaction for app router routes', async ({ page }) | |||
|
|
|||
| const serverComponentTransactionPromise = waitForTransaction('nextjs-app-dir', async transactionEvent => { | |||
| return ( | |||
| transactionEvent?.transaction === 'GET /server-component/parameter/foo/bar/baz' && | |||
| // It seems to differ between Next.js versions whether the route is parameterized or not | |||
There was a problem hiding this comment.
This seems bad and something we should fix. Doesn't this mean paramaterization breaks in the newest nextjs version?
There was a problem hiding this comment.
It's the newer versions that have the parameterized routes. Me and Francesco agreed that relay parameterization is good enough that we can just delegate the parameterization to Next.js. If it breaks, it breaks.
All of that shouldn't block this PR though.
AbhiPrasad
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/getsentry/sentry-javascript/actions/runs/9889158043