test(solidstart): Add client performance e2e tests #12895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
added
the
Package: solidstart
lforst
approved these changes
Jul 12, 2024
|
|
||
| test('sends a pageload transaction', async ({ page }) => { | ||
| const transactionPromise = waitForTransaction('solidstart', async transactionEvent => { | ||
| return !!transactionEvent?.transaction && transactionEvent.contexts?.trace?.op === 'pageload'; |
There was a problem hiding this comment.
You probably want to assert for a particular transaction name, otherwise the tests are gonna start leaking once you add more page.goto()s
| // The sentry solidRouterBrowserTracingIntegration tries to update such | ||
| // transactions with the proper name once the `useLocation` hook triggers. | ||
| const navigationTxnPromise = waitForTransaction('solidstart', async transactionEvent => { | ||
| return !!transactionEvent?.transaction && transactionEvent.contexts?.trace?.op === 'navigation'; |
There was a problem hiding this comment.
The waitForTransaction here and the one in the test above may leak into eachother.
| contexts: { | ||
| trace: { | ||
| op: 'pageload', | ||
| origin: 'auto.pageload.browser', |
There was a problem hiding this comment.
Follow up task: We likely want to emit auto.pageload.solidstart.router here.
There was a problem hiding this comment.
Thanks, will update this in a follow up PR.
| contexts: { | ||
| trace: { | ||
| op: 'navigation', | ||
| origin: 'auto.navigation.solid.solidrouter', |
There was a problem hiding this comment.
Follow-up, this should probably be solidstart.solidrouter
lforst
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.