Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(profiling-node): add detailed docs on how to build bindings #12900

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Jul 12, 2024

Add better build docs on how to build profiling binaries from source #12899

@JonasBa JonasBa requested a review from AbhiPrasad July 12, 2024 16:17
@AbhiPrasad AbhiPrasad changed the title profiling: add detailed docs on how to build bindings docs(profiling-node): add detailed docs on how to build bindings Jul 12, 2024
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We should def also add this to https://docs.sentry.io/platforms/javascript/guides/node/profiling/ (or link to this readme from there)

@AbhiPrasad AbhiPrasad merged commit eaf6055 into develop Jul 12, 2024
30 checks passed
@AbhiPrasad AbhiPrasad deleted the jb/profiling/build-docs branch July 12, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants