Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build: Pin to Node 22.4" #13029

Merged
merged 1 commit into from
Jul 24, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [14, 16, 18, 20, 22.4]
node: [14, 16, 18, 20, 22]
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v4
Expand Down Expand Up @@ -579,7 +579,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [14, 16, 18, 20, 22.4]
node: [14, 16, 18, 20, 22]
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v4
Expand Down Expand Up @@ -816,12 +816,12 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [14, 16, 18, 20, 22.4]
node: [14, 16, 18, 20, 22]
typescript:
- false
include:
# Only check typescript for latest version (to streamline CI)
- node: 22.4
- node: 22
typescript: '3.8'
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
Expand Down Expand Up @@ -858,7 +858,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [18, 20, 22.4]
node: [18, 20, 22]
remix: [1, 2]
# Remix v2 only supports Node 18+, so run 16 tests separately
include:
Expand Down Expand Up @@ -1384,7 +1384,7 @@ jobs:
- os: ubuntu-20.04
node: 20
- os: ubuntu-20.04
node: 22.4
node: 22

# x64 musl
- os: ubuntu-20.04
Expand All @@ -1398,7 +1398,7 @@ jobs:
node: 20
- os: ubuntu-20.04
container: node:22-alpine3.18
node: 22.4
node: 22

# arm64 glibc
- os: ubuntu-20.04
Expand All @@ -1412,7 +1412,7 @@ jobs:
node: 20
- os: ubuntu-20.04
arch: arm64
node: 22.4
node: 22

# arm64 musl
- os: ubuntu-20.04
Expand All @@ -1430,7 +1430,7 @@ jobs:
- os: ubuntu-20.04
arch: arm64
container: node:22-alpine3.18
node: 22.4
node: 22

# macos x64
- os: macos-13
Expand All @@ -1443,7 +1443,7 @@ jobs:
node: 20
arch: x64
- os: macos-13
node: 22.4
node: 22
arch: x64

# macos arm64
Expand All @@ -1461,7 +1461,7 @@ jobs:
target_platform: darwin
- os: macos-13
arch: arm64
node: 22.4
node: 22
target_platform: darwin

# windows x64
Expand All @@ -1475,7 +1475,7 @@ jobs:
node: 20
arch: x64
- os: windows-2022
node: 22.4
node: 22
arch: x64

steps:
Expand Down
Loading