Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(profiling-node): Switch to vitest #13030

Closed
wants to merge 2 commits into from

Conversation

AbhiPrasad
Copy link
Member

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@AbhiPrasad AbhiPrasad force-pushed the abhi-vitest-profiling-node branch from 4e8f20b to 0a462ba Compare July 24, 2024 01:25
@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented Jul 24, 2024

So vitest doesn't like require (obviously in restrospect)

I can use createRequire instead, @JonasBa what do you think?

Context on why we are porting to vitest: #11084

Edit: done in ef8ce53

@AbhiPrasad
Copy link
Member Author

alright I think our current vitest version has too many bugs with native bindings - we need to upgrade to v2 before we try this again.

@AbhiPrasad AbhiPrasad closed this Jul 24, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-vitest-profiling-node branch July 24, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant