feat(core): Use the ignoreErrors
logic for failed transactions
#13084
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint
) & (yarn test
).Hello there!
This change tries to fix a behavior with the transactions feature.
The behavior is straightforward: it happens when we have some entries in our
ignoreErrors
, but when some of these errors happen, the transactions are still being marked with theinternal_error
status.This is harmful in our case because we have some alerts set up for
%
of transaction failures, but we don't care about some of the errors that happen.This pretty much a feature request disguised as a PR. If someone from product sees this, I would love to read if that's the right idea our you folks have something else in mind.
Thank you!