Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(nestjs): Switch to explicit vitest imports #13214

Merged
merged 1 commit into from
Aug 6, 2024
Merged

test(nestjs): Switch to explicit vitest imports #13214

merged 1 commit into from
Aug 6, 2024

Conversation

AbhiPrasad
Copy link
Member

As per https://vitest.dev/config/#globals

By default, vitest does not provide global APIs for explicitness

I think we should follow vitest defaults here and explicitly import in the APIs that we need. This refactors our Nestjs SDK tests to do so.

ref #11084

@AbhiPrasad AbhiPrasad requested a review from nicohrubec August 2, 2024 22:46
@AbhiPrasad AbhiPrasad self-assigned this Aug 2, 2024
@AbhiPrasad AbhiPrasad mentioned this pull request Aug 2, 2024
Open
nicohrubec
nicohrubec approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@nicohrubec nicohrubec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@AbhiPrasad AbhiPrasad merged commit 0666eb5 into develop Aug 6, 2024
102 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-vitest-nestjs branch August 6, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicohrubec nicohrubec nicohrubec approved these changes

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @nicohrubec