Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sveltekit): Fix SvelteKit Cloudflare usage #14672
base: develop
Are you sure you want to change the base?
fix(sveltekit): Fix SvelteKit Cloudflare usage #14672
Changes from 8 commits
fc47659
31aa1d4
dc969b9
218c2cf
5aa9d54
28b2fd3
dc510d2
2c443a8
a43ecc4
1f27492
db5e5bc
78724a2
d0d2dbb
df8f314
ef78c1b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not directly applicable to this line but: I had to make this change to the
node
export to start the build:However, even after this change, I get another error a bit later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @Lms24 if this isn't the right place to discuss this, but is there any reason why we don't make this change in a separate PR?
I'm having an issue where trying to import
import * as Sentry from '@sentry/sveltekit';
using ESM in Node.JS has all the@sentry/node
imports underSentry.default
, and the above change seems to fix it.From reading #9872 (comment), it looks like ESM used to be broken, but I think 7f2e804 might have fixed it? But a similar change for remix seems to have not worked: #12742
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aloisklink sorry for only seeing your comment now: I agree, we should make this change separately. Thing is, as far as I know, SvelteKit transpiles to CJS (at least for Node-based environments). So I'm a bit hesitant to add an ESM entry point, especially because this works even less well than it currently works in CJS, with OpenTelemetry.
Feel free to submit a PR and let's see what our tests have to see