test(astro): Fix Astro 4 e2e test #14816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the title
This was referenced Dec 20, 2024
mydea
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our Astro-4 E2E test app, Astro's Node adapter was pinned to a bad version that didn'T work correctly with newer Astro versions. We pinned the Astro version a while ago in #14030 to unblock CI but looks like we just didn't follow up with investigating what caused the issue back then.
This came up again when dependabot tried to bump the Astro version in #14781 and #14807 and as a result #14808 was opened.
This PR now
astroto the latest v4 version (which is why I closed chore(deps): Bump astro from 4.13.3 to 4.16.18 in /dev-packages/e2e-tests/test-applications/astro-4 #14807)closes #14808