Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(svelte): Remove SvelteKit detection #15313

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 5, 2025

When we first created the Svelte SDK, we wanted to gauge how often it is used in a SvelteKit application. Therefore we added some SvelteKit detection logic to annotate events coming from the Svelte SDK. Since we have a SvelteKit SDK now, we don't need to track this anymore. Saves a few bytes, too.

This PR therefore removes the detection and event processing logic

@Lms24 Lms24 self-assigned this Feb 5, 2025
@Lms24 Lms24 requested a review from mydea February 5, 2025 15:19
Copy link
Contributor

github-actions bot commented Feb 5, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.89 KB - -
@sentry/browser - with treeshaking flags 22.76 KB - -
@sentry/browser (incl. Tracing) 35.77 KB - -
@sentry/browser (incl. Tracing, Replay) 72.58 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.13 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.82 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.56 KB - -
@sentry/browser (incl. Feedback) 39.83 KB - -
@sentry/browser (incl. sendFeedback) 27.52 KB - -
@sentry/browser (incl. FeedbackAsync) 32.3 KB - -
@sentry/react 24.73 KB - -
@sentry/react (incl. Tracing) 37.67 KB - -
@sentry/vue 27.09 KB - -
@sentry/vue (incl. Tracing) 37.47 KB - -
@sentry/svelte 22.93 KB -0.42% -97 B 🔽
CDN Bundle 24.2 KB - -
CDN Bundle (incl. Tracing) 35.91 KB - -
CDN Bundle (incl. Tracing, Replay) 70.56 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 75.7 KB - -
CDN Bundle - uncompressed 70.76 KB - -
CDN Bundle (incl. Tracing) - uncompressed 106.64 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 217.49 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.06 KB - -
@sentry/nextjs (client) 38.63 KB - -
@sentry/sveltekit (client) 36.2 KB -0.23% -85 B 🔽
@sentry/node 156.51 KB - -
@sentry/node - without tracing 97.52 KB - -
@sentry/aws-serverless 107 KB - -

View base workflow run

Copy link

codecov bot commented Feb 5, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
21 1 20 0
View the full list of 1 ❄️ flaky tests
sdk.test.ts SDK-internal behaviorInjects fetch proxy script for SvelteKit<2.16.0

Flake rate in main: 30.00% (Passed 14 times, Failed 6 times)

Stack Traces | 0.139s run time
sdk.test.ts:4:3 Injects fetch proxy script for SvelteKit<2.16.0

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@Lms24 Lms24 requested review from a team and s1gr1d and removed request for a team February 5, 2025 15:37
@Lms24 Lms24 merged commit 3220902 into develop Feb 5, 2025
36 checks passed
@Lms24 Lms24 deleted the lms/ref-svelte-remove-detectSveltekit branch February 5, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants