perf(core): Remove usage of addNonEnumerableProperty from span utils #15765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
added a commit
that referenced
this pull request
Mar 21, 2025
ref #15725 (comment) Similar to the work done in #15765 we can avoid usage of `addNonEnumerableProperty` with usage of a `WeakSet`.
|
No clue why this is failing. I'm going to open up individual PRs for this, perhaps that will help |
This was referenced Mar 24, 2025
AbhiPrasad
force-pushed
the
abhi-remove-addNonEnumerableProperty-from-span-utils
branch
from
a87a0de to
a416137
Compare
|
Seems like #15811 is causing the issue. Reverting changes in |
|
nvm 😢 |
AbhiPrasad
deleted the
abhi-remove-addNonEnumerableProperty-from-span-utils
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #15725 (comment)
addNonEnumerablePropertyis pretty expensive because ofObject.defineProperty, so this changes usage of span utils (which are called frequently) to avoid usage ofaddNonEnumerableProperty.addNonEnumerablePropertyis replaced with weak maps, which has the added benefit of being more GC friendly (addNonEnumerablePropertycauses hard references to be created between the objects).The only downside of switching to this approach is that we lose the
try catchbuilt intoaddNonEnumerableProperty, but I think thats fine given the nature of the changed methods.