Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Celery tests in Potel #3772

Open
wants to merge 15 commits into
base: potel-base
Choose a base branch
from

Conversation

antonpirker
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 13, 2024

❌ 5339 Tests Failed:

Tests completed Failed Passed Skipped
17916 5339 12577 4121
View the top 3 failed tests by shortest run time
tests.test_scope test_get_isolation_scope_tags
Stack Traces | 0.001s run time
tests/test_scope.py:332: in test_get_isolation_scope_tags
    assert tags_scope1 == tags_scope2 == {"tag1": "value"}
E   AssertionError: assert {'tag.global': 99, 'tag.inner': 'foo', 'tag1': 'value'} == {'tag1': 'value'}
E     
E     Common items:
E     {'tag1': 'value'}
E     Left contains 2 more items:
E     {'tag.global': 99, 'tag.inner': 'foo'}
E     
E     Full diff:
E       {
E     +     'tag.global': 99,
E     +     'tag.inner': 'foo',
E           'tag1': 'value',
E       }
tests.test_scope test_with_use_isolation_scope_data
Stack Traces | 0.001s run time
tests/test_scope.py:507: in test_with_use_isolation_scope_data
    assert current_scope_in._tags == {"before_current_scope": 1}
E   AssertionError: assert {'tag1': 'value', 'before_current_scope': 1} == {'before_current_scope': 1}
E     
E     Common items:
E     {'before_current_scope': 1}
E     Left contains 1 more item:
E     {'tag1': 'value'}
E     
E     Full diff:
E       {
E           'before_current_scope': 1,
E     +     'tag1': 'value',
E       }
tests.test_scope test_with_use_isolation_scope_data
Stack Traces | 0.001s run time
tests/test_scope.py:507: in test_with_use_isolation_scope_data
    assert current_scope_in._tags == {"before_current_scope": 1}
E   AssertionError: assert {'tag1': 'value', 'before_current_scope': 1} == {'before_current_scope': 1}
E     
E     Common items:
E     {'before_current_scope': 1}
E     Left contains 1 more item:
E     {'tag1': 'value'}
E     
E     Full diff:
E       {
E           'before_current_scope': 1,
E     +     'tag1': 'value',
E       }

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Comment on lines 223 to 228
assert execution_event["spans"][0] == ApproxDict({
"trace_id": str(span.trace_id),
"same_process_as_parent": True,
"op": "queue.process",
"description": "dummy_task",
})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just makes the diff of failing tests way easier to read

sentry_sdk/tracing.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants