Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpack WSGI environ into span attrs accessible in traces sampler #3775

Merged
merged 34 commits into from
Nov 15, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Nov 14, 2024

  • Instead of passing wsgi_environ to the traces_sampler via sampling_context, unpack it into several span attributes and make those accessible in the traces_sampler.
  • Add url.query for ASGI.

Part of #3746

@sentrivana sentrivana mentioned this pull request Nov 14, 2024
12 tasks
Copy link

codecov bot commented Nov 14, 2024

❌ 1716 Tests Failed:

Tests completed Failed Passed Skipped
20056 1716 18340 4413
View the top 1 failed tests by shortest run time
tests.test_utils test_datetime_from_isoformat[2021-01-01T00:00:00.000000-00:00-expected_output4]
Stack Traces | 0.001s run time
tests/test_utils.py:109: in test_datetime_from_isoformat
    assert datetime_from_isoformat(input_str) == expected_output, input_str
E   NameError: name 'datetime_from_isoformat' is not defined
View the full list of 2 ❄️ flaky tests
tests.test_utils test_datetime_from_isoformat[2021-01-01T00:00:00.000000-0000-expected_output6]

Flake rate in main: 58.06% (Passed 39 times, Failed 54 times)

Stack Traces | 0.001s run time
tests/test_utils.py:109: in test_datetime_from_isoformat
    assert datetime_from_isoformat(input_str) == expected_output, input_str
E   NameError: name 'datetime_from_isoformat' is not defined
tests.test_scope test_with_isolation_scope_data

Flake rate in main: 99.17% (Passed 2 times, Failed 238 times)

Stack Traces | 0.001s run time
tests/test_scope.py:387: in test_with_isolation_scope_data
    assert scope._tags == {"before_isolation_scope": 1}
E   AssertionError: assert {} == {'before_isolation_scope': 1}
E     
E     Right contains 1 more item:
E     {'before_isolation_scope': 1}
E     
E     Full diff:
E     + {}
E     - {
E     -     'before_isolation_scope': 1,
E     - }

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@sentrivana sentrivana marked this pull request as ready for review November 15, 2024 08:31
@sentrivana sentrivana merged commit 571c5cd into potel-base Nov 15, 2024
37 of 125 checks passed
@sentrivana sentrivana deleted the ivana/custom-sampling-context-wsgi branch November 15, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants