Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements Report a Bug button #4378

Draft
wants to merge 115 commits into
base: antonis/feedback-modal-ui
Choose a base branch
from
Draft

Implements Report a Bug button #4378

wants to merge 115 commits into from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Dec 16, 2024 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Depends on: #4492

📜 Description

Implements feedback button that launches the feedback form using the auto-injected feedback widget

💡 Motivation and Context

Part of #4302

💚 How did you test it?

Manual testing with the sample app

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

antonis and others added 30 commits November 27, 2024 14:00
@antonis
Update the client implementation to use the new capture feedback js api
817eac8
@antonis
Updates SDK API
5370a99
@antonis
Adds new feedback button in the sample
42e2fa1
@antonis
Adds changelog
514b102
@antonis
Removes unused mock
0935bbd
@antonis @krystofwoldrich
Update CHANGELOG.md
9ea5496 
Co-authored-by: Krystof Woldrich <[email protected]>
@antonis
Directly use captureFeedback from sentry/core
da0d4ac
@antonis
Use import from core
3e36c6d
@antonis
Fixes imports order lint issue
5f3df64
@antonis
Fixes build issue
71b28e8
@antonis
Adds captureFeedback tests from sentry-javascript
f9d2b59
@krystofwoldrich
Update CHANGELOG.md
d05d531
@antonis
Only deprecate client captureUserFeedback
2bb104b
@antonis
Add simple form UI
4339274
@antonis
Adds basic form functionality
6ce799b
@antonis
Update imports
f2cefc6
@antonis
Update imports
694ee33
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33
@antonis
Remove useState hook to avoid multiple react instances issues
034efde
@antonis
Move types and styles in different files
67a492d
@antonis
Removes attachment button to be added back separately along with the …
8eaa61d 
…implementation
@antonis
Add basic field validation
0b88cc5
@antonis
Adds changelog
ae11b8d
@antonis
Updates changelog
7f2ca06
@antonis
Updates changelog
064b6c4
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a
@antonis
Trim whitespaces from the submitted feedback
e21718a
@antonis
Adds tests
407f179
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005
@antonis
Renames FeedbackFormScreen to FeedbackForm
ddade00
@antonis antonis marked this pull request as draft January 10, 2025 09:22
Base automatically changed from antonis/3859-newCaptureFeedbackAPI-Form to feedback-ui January 10, 2025 10:32
@antonis antonis mentioned this pull request Jan 10, 2025
Draft
10 tasks
@krystofwoldrich
Copy link
Member

The latest feedback-ui needs to be merged in, at the moment all the FeedbackForm files show as newly added.

@antonis
Copy link
Collaborator Author

antonis commented Jan 16, 2025

The latest feedback-ui needs to be merged in, at the moment all the FeedbackForm files show as newly added.

Yep, It was based on the incomplete "autoinjection" that was reverted 😓
I'll clean this up @krystofwoldrich and mark it as ready for review.

@krystofwoldrich
Copy link
Member

I know this is still a draft, but I checked the code and added my thoughts.

@antonis antonis mentioned this pull request Jan 14, 2025
Closed
This was referenced Jan 24, 2025
Open
Closed
@krystofwoldrich krystofwoldrich changed the title (3.1) Implements Report a Bug button Implements Report a Bug button Jan 24, 2025
@antonis
Merge branch 'feedback-ui' into antonis/4358-Feedback-Form-Autoinject…
22fd47b 
…-Button

# Conflicts:
#	CHANGELOG.md
#	packages/core/src/js/feedback/FeedbackForm.styles.ts
#	packages/core/src/js/feedback/FeedbackForm.tsx
#	packages/core/src/js/feedback/FeedbackForm.types.ts
#	packages/core/src/js/feedback/defaults.ts
#	packages/core/src/js/index.ts
#	packages/core/test/feedback/FeedbackForm.test.tsx
#	samples/react-native/src/App.tsx
#	samples/react-native/src/Screens/ErrorsScreen.tsx
@antonis antonis changed the base branch from feedback-ui to antonis/feedback-modal-ui February 3, 2025 09:45
@antonis
Copy link
Collaborator Author

antonis commented Feb 3, 2025 •
edited
Loading

The latest feedback-ui needs to be merged in, at the moment all the FeedbackForm files show as newly added.

Yep, It was based on the incomplete "autoinjection" that was reverted 😓
I'll clean this up @krystofwoldrich and mark it as ready for review.

I've updated this PR with the latest implementation.
I'm leaving it in draft state for now since there are open questions on how the button should behave and how much it should be configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich left review comments

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feedback Form: Implement Report a Bug button
3 participants
@antonis @krystofwoldrich @lucas-zimerman