Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Fixes Android SDK v8 breakages and deprecations #4490

Open
wants to merge 18 commits into
base: deps/scripts/update-android.sh
Choose a base branch
from
Open

chore(deps): Fixes Android SDK v8 breakages and deprecations #4490

wants to merge 18 commits into from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Jan 28, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on chore(deps): update Android SDK to v8.1.0

📜 Description

I've opened this PR to fix Android SDK v8.0.0 breakages and deprecations without interfering with the update-android.sh ci automation and to get a 2nd eye on the changes.

⚠️ The changes on this PR will conflict with the Android refactoring for the capture app start errors feature. I expect that porting the 5 changes/commits in the new implementation should be straightforward.

💡 Motivation and Context

Migration guide from version 7.x to 8.0

Breakages

Deprecations

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 449.94 ms 430.71 ms -19.22 ms
Size 17.75 MiB 20.13 MiB 2.38 MiB

Baseline results on branch: deps/scripts/update-android.sh

Startup times

Revision Plain With Sentry Diff
3492efc 460.14 ms 453.82 ms -6.32 ms
9a14ddc 464.38 ms 447.52 ms -16.86 ms
8935554 581.75 ms 597.92 ms 16.17 ms
3a5c9df 469.83 ms 454.33 ms -15.50 ms
3395e84 467.15 ms 462.28 ms -4.87 ms
be73e1a 418.89 ms 410.35 ms -8.54 ms
9ce73cb 430.10 ms 424.42 ms -5.68 ms
d5edb06 485.92 ms 502.18 ms 16.27 ms
2f36acc 439.50 ms 428.00 ms -11.50 ms
bd81ebd 451.26 ms 454.69 ms 3.43 ms

App size

Revision Plain With Sentry Diff
3492efc 17.74 MiB 20.08 MiB 2.35 MiB
9a14ddc 17.74 MiB 20.09 MiB 2.36 MiB
8935554 17.75 MiB 20.11 MiB 2.37 MiB
3a5c9df 17.74 MiB 20.09 MiB 2.35 MiB
3395e84 17.74 MiB 20.08 MiB 2.35 MiB
be73e1a 17.74 MiB 20.08 MiB 2.34 MiB
9ce73cb 17.74 MiB 20.10 MiB 2.36 MiB
d5edb06 17.73 MiB 20.11 MiB 2.38 MiB
2f36acc 17.74 MiB 20.08 MiB 2.35 MiB
bd81ebd 17.74 MiB 20.08 MiB 2.34 MiB

Previous results on branch: antonis/android-sdk-8

Startup times

Revision Plain With Sentry Diff
f703940 437.08 ms 449.29 ms 12.21 ms
13aaa0b 381.94 ms 491.94 ms 110.00 ms
9af1463 403.72 ms 386.56 ms -17.16 ms
43ce2a5 335.96 ms 352.66 ms 16.70 ms

App size

Revision Plain With Sentry Diff
f703940 17.75 MiB 20.12 MiB 2.37 MiB
13aaa0b 17.75 MiB 20.13 MiB 2.38 MiB
9af1463 17.75 MiB 20.12 MiB 2.37 MiB
43ce2a5 17.75 MiB 20.13 MiB 2.38 MiB

@antonis antonis marked this pull request as ready for review January 28, 2025 11:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 348.83 ms 389.59 ms 40.76 ms
Size 7.15 MiB 8.39 MiB 1.24 MiB

Baseline results on branch: deps/scripts/update-android.sh

Startup times

Revision Plain With Sentry Diff
8935554+dirty 363.32 ms 396.52 ms 33.20 ms
be73e1a+dirty 397.04 ms 452.15 ms 55.11 ms
3a5c9df+dirty 396.43 ms 461.18 ms 64.75 ms
9a14ddc+dirty 405.31 ms 454.08 ms 48.77 ms
3395e84+dirty 395.06 ms 414.32 ms 19.26 ms
2f36acc+dirty 386.02 ms 426.77 ms 40.75 ms
d5edb06+dirty 378.54 ms 414.26 ms 35.72 ms
3492efc+dirty 441.40 ms 554.44 ms 113.05 ms
9ce73cb+dirty 611.28 ms 680.94 ms 69.66 ms
bd81ebd+dirty 394.55 ms 442.16 ms 47.61 ms

App size

Revision Plain With Sentry Diff
8935554+dirty 7.15 MiB 8.38 MiB 1.23 MiB
be73e1a+dirty 7.15 MiB 8.35 MiB 1.20 MiB
3a5c9df+dirty 7.15 MiB 8.37 MiB 1.22 MiB
9a14ddc+dirty 7.15 MiB 8.37 MiB 1.22 MiB
3395e84+dirty 7.15 MiB 8.35 MiB 1.21 MiB
2f36acc+dirty 7.15 MiB 8.35 MiB 1.21 MiB
d5edb06+dirty 7.15 MiB 8.39 MiB 1.24 MiB
3492efc+dirty 7.15 MiB 8.35 MiB 1.21 MiB
9ce73cb+dirty 7.15 MiB 8.37 MiB 1.22 MiB
bd81ebd+dirty 7.15 MiB 8.35 MiB 1.20 MiB

Previous results on branch: antonis/android-sdk-8

Startup times

Revision Plain With Sentry Diff
43ce2a5+dirty 412.87 ms 461.96 ms 49.08 ms
9af1463+dirty 287.04 ms 313.50 ms 26.46 ms
13aaa0b+dirty 382.52 ms 440.69 ms 58.17 ms
f703940+dirty 350.96 ms 390.84 ms 39.88 ms

App size

Revision Plain With Sentry Diff
43ce2a5+dirty 7.15 MiB 8.39 MiB 1.24 MiB
9af1463+dirty 7.15 MiB 8.39 MiB 1.24 MiB
13aaa0b+dirty 7.15 MiB 8.39 MiB 1.24 MiB
f703940+dirty 7.15 MiB 8.39 MiB 1.24 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.90 ms 1232.92 ms -3.98 ms
Size 3.19 MiB 4.26 MiB 1.08 MiB

Baseline results on branch: deps/scripts/update-android.sh

Startup times

Revision Plain With Sentry Diff
9a14ddc+dirty 1232.94 ms 1236.79 ms 3.85 ms
b865343+dirty 1225.35 ms 1231.31 ms 5.95 ms
3a5c9df+dirty 1236.56 ms 1233.51 ms -3.05 ms
d5edb06+dirty 1234.31 ms 1237.86 ms 3.54 ms
2f36acc+dirty 1245.12 ms 1249.65 ms 4.53 ms
bd81ebd+dirty 1225.10 ms 1219.23 ms -5.88 ms
3492efc+dirty 1228.87 ms 1225.96 ms -2.91 ms
be73e1a+dirty 1246.69 ms 1243.78 ms -2.92 ms
3395e84+dirty 1223.04 ms 1215.24 ms -7.80 ms
9ce73cb+dirty 1239.83 ms 1236.67 ms -3.17 ms

App size

Revision Plain With Sentry Diff
9a14ddc+dirty 2.92 MiB 3.67 MiB 770.02 KiB
b865343+dirty 2.92 MiB 3.67 MiB 770.03 KiB
3a5c9df+dirty 2.92 MiB 3.67 MiB 772.45 KiB
d5edb06+dirty 2.92 MiB 3.69 MiB 794.20 KiB
2f36acc+dirty 2.92 MiB 3.66 MiB 758.67 KiB
bd81ebd+dirty 2.92 MiB 3.66 MiB 756.69 KiB
3492efc+dirty 2.92 MiB 3.66 MiB 758.56 KiB
be73e1a+dirty 2.92 MiB 3.66 MiB 757.11 KiB
3395e84+dirty 2.92 MiB 3.66 MiB 758.53 KiB
9ce73cb+dirty 2.92 MiB 3.69 MiB 790.61 KiB

Previous results on branch: antonis/android-sdk-8

Startup times

Revision Plain With Sentry Diff
13aaa0b+dirty 1227.24 ms 1233.71 ms 6.47 ms
43ce2a5+dirty 1222.30 ms 1210.89 ms -11.40 ms
9af1463+dirty 1217.24 ms 1215.55 ms -1.69 ms
f703940+dirty 1227.41 ms 1221.96 ms -5.45 ms

App size

Revision Plain With Sentry Diff
13aaa0b+dirty 3.19 MiB 4.26 MiB 1.08 MiB
43ce2a5+dirty 3.19 MiB 4.27 MiB 1.08 MiB
9af1463+dirty 3.19 MiB 4.25 MiB 1.07 MiB
f703940+dirty 3.19 MiB 4.25 MiB 1.07 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1210.71 ms 1219.10 ms 8.40 ms
Size 2.63 MiB 3.70 MiB 1.06 MiB

Baseline results on branch: deps/scripts/update-android.sh

Startup times

Revision Plain With Sentry Diff
9a14ddc+dirty 1232.77 ms 1243.57 ms 10.81 ms
b865343+dirty 1230.16 ms 1220.90 ms -9.27 ms
3a5c9df+dirty 1234.80 ms 1237.12 ms 2.33 ms
d5edb06+dirty 1236.40 ms 1245.30 ms 8.90 ms
2f36acc+dirty 1232.21 ms 1227.70 ms -4.51 ms
bd81ebd+dirty 1230.20 ms 1222.30 ms -7.90 ms
3492efc+dirty 1225.24 ms 1227.57 ms 2.33 ms
be73e1a+dirty 1213.57 ms 1224.11 ms 10.54 ms
3395e84+dirty 1233.63 ms 1231.83 ms -1.81 ms
9ce73cb+dirty 1234.37 ms 1238.80 ms 4.42 ms

App size

Revision Plain With Sentry Diff
9a14ddc+dirty 2.36 MiB 3.10 MiB 757.53 KiB
b865343+dirty 2.36 MiB 3.10 MiB 757.51 KiB
3a5c9df+dirty 2.36 MiB 3.10 MiB 759.79 KiB
d5edb06+dirty 2.36 MiB 3.14 MiB 793.32 KiB
2f36acc+dirty 2.36 MiB 3.10 MiB 753.45 KiB
bd81ebd+dirty 2.36 MiB 3.10 MiB 752.31 KiB
3492efc+dirty 2.36 MiB 3.10 MiB 753.42 KiB
be73e1a+dirty 2.36 MiB 3.10 MiB 752.64 KiB
3395e84+dirty 2.36 MiB 3.10 MiB 753.37 KiB
9ce73cb+dirty 2.36 MiB 3.12 MiB 779.42 KiB

Previous results on branch: antonis/android-sdk-8

Startup times

Revision Plain With Sentry Diff
13aaa0b+dirty 1227.88 ms 1225.39 ms -2.49 ms
43ce2a5+dirty 1228.81 ms 1221.27 ms -7.54 ms
9af1463+dirty 1231.92 ms 1232.04 ms 0.12 ms
f703940+dirty 1219.50 ms 1223.02 ms 3.52 ms

App size

Revision Plain With Sentry Diff
13aaa0b+dirty 2.63 MiB 3.70 MiB 1.06 MiB
43ce2a5+dirty 2.63 MiB 3.70 MiB 1.07 MiB
9af1463+dirty 2.63 MiB 3.69 MiB 1.06 MiB
f703940+dirty 2.63 MiB 3.69 MiB 1.05 MiB

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from d2b541e to 0316113 Compare January 29, 2025 07:45
lucas-zimerman
lucas-zimerman approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are looking good! LGTM!

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Jan 30, 2025 •
edited
Loading

We should evaluate if it's okay to release this in a feature update, or wait for RN SDK v7.

Generally we don't have to do a major due to native SDK major, but we should confirm if minSdkVersion bump to 21 and others are not issue for min support RN version 0.65.

@antonis
Copy link
Collaborator Author

antonis commented Jan 30, 2025

We should evaluate if it's okay to release this in a feature update, or wait for RN SDK v7.

That's a good point @krystofwoldrich 👍
Though this version bump has a long changelog my understanding from the migration guide is that it is safe to bump since the changes needed on our side were minimal.
That said it would be nice to have a confirmation from the Android team.

Generally we don't have to do a major due to native SDK major, but we should confirm if minSdkVersion bump to 21 and others are not issue for min support RN version 0.65.

Currently the react native sdk defaults to minSdk 21 (though our gradle is not enforcing that).
Given that the version 21 bump has been communicated in our v5 migration guide this might not be blocking.

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch 2 times, most recently from fd074dc to b8e6e0d Compare January 31, 2025 05:53
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from b8e6e0d to 246e13b Compare January 31, 2025 07:16
@antonis
Merge branch 'deps/scripts/update-android.sh' into antonis/android-sdk-8
0d54111 
# Conflicts:
#	CHANGELOG.md
#	packages/core/android/build.gradle
@antonis antonis changed the title chore(deps): Fixes Android SDK v8.0.0 breakages and deprecations chore(deps): Fixes Android SDK v8 breakages and deprecations Jan 31, 2025
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from 246e13b to 6f276a6 Compare January 31, 2025 16:32
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from 6f276a6 to ac72161 Compare February 3, 2025 07:16
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from ac72161 to 3b4031b Compare February 3, 2025 08:30
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from 3b4031b to 65f3705 Compare February 3, 2025 09:14
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch 4 times, most recently from 9efcaf0 to 159502e Compare February 4, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antonis @krystofwoldrich @lucas-zimerman @web-flow