Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for ignoring specific React components during annotation #4517

Merged
merged 3 commits into from
Feb 10, 2025
Merged

feat: Add support for ignoring specific React components during annotation #4517

merged 3 commits into from
Feb 10, 2025

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • New feature

📜 Description

This change introduces the ability to configure which React components should be ignored during Sentry's component annotation process. The modification allows users to specify an array of component names to exclude from instrumentation via the annotateReactComponents option.

💡 Motivation and Context

allow the latest features from the undelaying annotation plugin

💚 How did you test it?

sample apps, unit tests

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

@krystofwoldrich
chore(deps): Bump @sentry/babel-plugin-component-annotate to v3.1.2
e323e94
@krystofwoldrich
feat: Add support for ignoring specific React components during annot…
24e290b 
…ation

This change introduces the ability to configure which React components should be ignored during Sentry's component annotation process. The modification allows users to specify an array of component names to exclude from instrumentation via the `annotateReactComponents` option.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2e2f4c7

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 450.67 ms 517.57 ms 66.90 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e540498+dirty 408.56 ms 480.00 ms 71.44 ms
ddc0552+dirty 405.80 ms 480.00 ms 74.20 ms
77680ec+dirty 393.50 ms 426.68 ms 33.18 ms
9cd0e9f+dirty 383.65 ms 418.65 ms 35.00 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
18ce5e8+dirty 389.26 ms 409.53 ms 20.27 ms
8c88ac7+dirty 402.72 ms 434.32 ms 31.60 ms
4161236+dirty 429.89 ms 498.74 ms 68.85 ms
0ebca77+dirty 360.94 ms 402.24 ms 41.30 ms

App size

Revision Plain With Sentry Diff
e540498+dirty 7.15 MiB 8.38 MiB 1.23 MiB
ddc0552+dirty 7.15 MiB 8.37 MiB 1.22 MiB
77680ec+dirty 7.15 MiB 8.35 MiB 1.20 MiB
9cd0e9f+dirty 7.15 MiB 8.35 MiB 1.20 MiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
18ce5e8+dirty 7.15 MiB 8.37 MiB 1.22 MiB
8c88ac7+dirty 7.15 MiB 8.35 MiB 1.20 MiB
4161236+dirty 7.15 MiB 8.38 MiB 1.23 MiB
0ebca77+dirty 7.15 MiB 8.22 MiB 1.07 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1213.61 ms 1223.71 ms 10.10 ms
Size 2.63 MiB 3.70 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e73d82f+dirty 1207.52 ms 1216.73 ms 9.21 ms
153419c+dirty 1221.06 ms 1227.80 ms 6.73 ms
ac41368+dirty 1226.65 ms 1237.90 ms 11.24 ms
9cab16b+dirty 1237.76 ms 1234.00 ms -3.76 ms
1332acb+dirty 1230.53 ms 1234.54 ms 4.01 ms
77680ec+dirty 1231.81 ms 1238.35 ms 6.54 ms
8ae23a7+dirty 1230.02 ms 1227.62 ms -2.40 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms
800171e+dirty 1229.96 ms 1232.87 ms 2.91 ms
b6f8ea2+dirty 1236.08 ms 1228.58 ms -7.50 ms

App size

Revision Plain With Sentry Diff
e73d82f+dirty 2.36 MiB 3.08 MiB 734.23 KiB
153419c+dirty 2.63 MiB 3.70 MiB 1.06 MiB
ac41368+dirty 2.36 MiB 3.14 MiB 793.46 KiB
9cab16b+dirty 2.36 MiB 3.08 MiB 737.23 KiB
1332acb+dirty 2.36 MiB 3.11 MiB 759.86 KiB
77680ec+dirty 2.36 MiB 3.10 MiB 753.42 KiB
8ae23a7+dirty 2.36 MiB 3.10 MiB 752.42 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB
800171e+dirty 2.63 MiB 3.69 MiB 1.05 MiB
b6f8ea2+dirty 2.63 MiB 3.68 MiB 1.05 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.45 ms 1228.22 ms 1.78 ms
Size 3.19 MiB 4.26 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e73d82f+dirty 1231.20 ms 1228.81 ms -2.40 ms
153419c+dirty 1225.12 ms 1221.31 ms -3.82 ms
ac41368+dirty 1226.69 ms 1229.96 ms 3.27 ms
9cab16b+dirty 1236.10 ms 1247.16 ms 11.06 ms
1332acb+dirty 1243.98 ms 1241.12 ms -2.86 ms
77680ec+dirty 1237.65 ms 1236.24 ms -1.41 ms
8ae23a7+dirty 1233.67 ms 1229.52 ms -4.15 ms
3853f43+dirty 1271.74 ms 1278.04 ms 6.30 ms
800171e+dirty 1222.94 ms 1235.82 ms 12.88 ms
b6f8ea2+dirty 1254.10 ms 1236.67 ms -17.43 ms

App size

Revision Plain With Sentry Diff
e73d82f+dirty 2.92 MiB 3.64 MiB 740.56 KiB
153419c+dirty 3.19 MiB 4.26 MiB 1.08 MiB
ac41368+dirty 2.92 MiB 3.69 MiB 794.29 KiB
9cab16b+dirty 2.92 MiB 3.64 MiB 743.06 KiB
1332acb+dirty 2.92 MiB 3.67 MiB 772.45 KiB
77680ec+dirty 2.92 MiB 3.66 MiB 758.54 KiB
8ae23a7+dirty 2.92 MiB 3.66 MiB 757.67 KiB
3853f43+dirty 2.92 MiB 3.41 MiB 503.54 KiB
800171e+dirty 3.19 MiB 4.25 MiB 1.06 MiB
b6f8ea2+dirty 3.19 MiB 4.25 MiB 1.06 MiB

Base automatically changed from kw-bump-js-babel-plugin to main February 10, 2025 10:51
@krystofwoldrich krystofwoldrich enabled auto-merge (squash) February 10, 2025 10:52
antonis
antonis approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich merged commit 3d63eb0 into main Feb 10, 2025
64 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-add-ignore-names-annotations branch February 10, 2025 10:58
@github-actions GitHub Actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 473.35 ms 482.65 ms 9.31 ms
Size 17.75 MiB 20.11 MiB 2.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0eacc98 431.88 ms 454.56 ms 22.68 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
b95b8af 454.05 ms 454.53 ms 0.48 ms
ddc0552 472.92 ms 460.66 ms -12.26 ms
e1ea4a8 506.82 ms 510.48 ms 3.66 ms
c2a4e9b 480.42 ms 485.60 ms 5.18 ms
728164b 414.34 ms 449.22 ms 34.88 ms
e5c9b8b 409.02 ms 426.66 ms 17.64 ms
484813b 434.55 ms 452.31 ms 17.75 ms
2ec71da 438.14 ms 460.46 ms 22.32 ms

App size

Revision Plain With Sentry Diff
0eacc98 17.75 MiB 20.11 MiB 2.37 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
b95b8af 17.73 MiB 20.11 MiB 2.37 MiB
ddc0552 17.74 MiB 20.09 MiB 2.35 MiB
e1ea4a8 17.74 MiB 20.08 MiB 2.34 MiB
c2a4e9b 17.73 MiB 20.06 MiB 2.33 MiB
728164b 17.73 MiB 19.85 MiB 2.12 MiB
e5c9b8b 17.73 MiB 19.83 MiB 2.10 MiB
484813b 17.73 MiB 20.07 MiB 2.33 MiB
2ec71da 17.73 MiB 20.10 MiB 2.37 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

@0Calories 0Calories Awaiting requested review from 0Calories

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @antonis