Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ref(metrics): Add metrics for script run times (#72223)" #73447

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

joshuarli
Copy link
Member

@joshuarli joshuarli commented Jun 27, 2024

This reverts commit 09cdabf. Wasn't roll forwardable anyways since make instlal-py-dev goes through do.sh, which I plan on removing.

Functionality will be preserved as part of getsentry/devenv#124 where span durations would work.

@joshuarli joshuarli requested review from a team as code owners June 27, 2024 17:49
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.01%. Comparing base (d76093b) to head (1af7b29).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #73447       +/-   ##
===========================================
+ Coverage   56.88%   78.01%   +21.12%     
===========================================
  Files        6626     6635        +9     
  Lines      296382   296678      +296     
  Branches    51043    51091       +48     
===========================================
+ Hits       168590   231444    +62854     
+ Misses     122970    58849    -64121     
- Partials     4822     6385     +1563     

see 1996 files with indirect coverage changes

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshuarli joshuarli merged commit e3b1b78 into master Jul 1, 2024
50 checks passed
@joshuarli joshuarli deleted the devenv-revert-thing branch July 1, 2024 18:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants