fix(issue-views): Fix endpoint sorting by last_visited to query for specific user #89960
+43
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
malwilley
commented
Apr 18, 2025
| GroupSearchViewLastVisited.objects.create( | ||
| user_id=user.id, | ||
| GroupSearchViewLastVisited.objects.create_or_update( | ||
| user_id=self.user.id, |
There was a problem hiding this comment.
The test util was attributing last_visited to the incoming user instead of the current user, which was what hid this error and caused the tests to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Last Visited" sort was acting very strangely, returning the wrong order and in some cases duplicate records. This was because the sort was pointing at the GroupSearchViewLastVisited model, but did not do any querying for the specific user.
Added a
last_visitedannotation that makes the correct query to fix this.