ref(distributions): Refactor fetching flags and their suspect scores #89962
+164
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
aliu39
reviewed
Apr 19, 2025
| refetch: () => void; | ||
| } | ||
|
|
||
| export default function useFlagDrawerData({ |
There was a problem hiding this comment.
Suggested change
| export default function useFlagDrawerData({ | |
| export default function useGroupFlagDrawerData({ |
To match file
| }, [filteredFlags, orderBy, sortBy]); | ||
|
|
||
| return { | ||
| allFlagCount: suspectFlags.length, |
There was a problem hiding this comment.
Suggested change
| allFlagCount: suspectFlags.length, | |
| allGroupFlagCount: suspectFlags.length, |
| }); | ||
|
|
||
| // Combine the flag and suspect data into SuspectGroupTag objects | ||
| const suspectFlags = useMemo(() => { |
There was a problem hiding this comment.
Suggested change
| const suspectFlags = useMemo(() => { | |
| const allFlagsWithScores = useMemo(() => { |
Or something that's not suspectFlags. When I read suspectFlags, I think tthe highlighted, most suspicious flags.
| isError: isSuspectEnabled ? isFlagsError || isSuspectError : isFlagsError, | ||
| isPending: isSuspectEnabled ? isFlagsPending || isSuspectPending : isFlagsPending, | ||
| refetch: () => { | ||
| refetchFlags(); |
There was a problem hiding this comment.
Is it useful to include the refetch for scores too?
| ); | ||
| }); | ||
| }, [data, search, tagValues]); | ||
| // const enableSuspectFlags = organization.features.includes('feature-flag-suspect-flags'); |
There was a problem hiding this comment.
Forgot to remove?
I think we can skip checking this FF for the debug UI. It's more for gating the endpoint, which should be enabled internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation of the new suspect flags table. The new table will call
useFlagDrawerData()and then show any flags that are over a specific threshold. But that table and all the ui stuff is a bunch of code, so i split this off separately.Once the new table starts calling
useFlagDrawerDatathen there'll be two spots that will share the same caches foruseGroupFeatureFlagsanduseGroupSuspectFlagScores; but all theuseMemocalls in here will double up the memory footprint; optimizing for sharing code over memory i guess.