Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(span): Use JsonViewer for JSON-like queries such as MongoDB #563

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

BYK
Copy link
Member

@BYK BYK commented Nov 19, 2024

Fixes #562.

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 11:50am

@Shubhdeep12
Copy link
Collaborator

Hi @BYK can you please add an envelope under overlay/_fixtures with mongodb queries. that would be helpful.
thanks

@Shubhdeep12
Copy link
Collaborator

Shubhdeep12 commented Nov 22, 2024

Hi @BYK can you please add an envelope under overlay/_fixtures with mongodb queries. that would be helpful. thanks

we can do this later. approving this PR now.

@Shubhdeep12 Shubhdeep12 enabled auto-merge (squash) November 22, 2024 09:30
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 12.00000% with 44 lines in your changes missing coverage. Please review.

Project coverage is 31.07%. Comparing base (5c0b162) to head (3cc1ceb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ons/sentry/components/traces/spans/SpanDetails.tsx 6.38% 44 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   31.15%   31.07%   -0.08%     
==========================================
  Files          83       83              
  Lines        5030     5052      +22     
  Branches       99       99              
==========================================
+ Hits         1567     1570       +3     
- Misses       3463     3482      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Shubhdeep12 Shubhdeep12 merged commit 7b9329c into main Nov 25, 2024
14 of 16 checks passed
@Shubhdeep12 Shubhdeep12 deleted the byk/feat/mongodb-format branch November 25, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MongoDB queries are not formatted
2 participants