-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the TODO #202
Draft
kneeyo1
wants to merge
2
commits into
main
Choose a base branch
from
kneeyo1/fix-todo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Clean up the TODO #202
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,12 @@ | ||
# TODO | ||
|
||
## 2014-03-13 | ||
|
||
- ending phase 1 | ||
|
||
- combined messages, like plan | ||
- @neo unlock | ||
- @neo apply | ||
- @ellison fix test suite -- update to new tag style, used in combined plan | ||
summary | ||
- @buck datadog ops events | ||
- remove the `if-not-ci` wrapper and it _may_ just work? | ||
`git grep if-not-ci` | ||
- run test suite in CI | ||
- put op github-app secrets into gha secrets | ||
- may need some security-as-code stuff to authorize gcloud? | ||
## ending phase 1 | ||
- @neo unlock all touched files. | ||
- @buck datadog ops events | ||
- remove the `if-not-ci` wrapper and it _may_ just work? `git grep if-not-ci` | ||
- run test suite in CI | ||
- put op github-app secrets into gha secrets | ||
- may need some security-as-code stuff to authorize gcloud? | ||
|
||
## Misc. Action Items | ||
|
||
|
@@ -51,20 +43,6 @@ Definition: All ops slices are subject to TACOS lock-on-PR. | |
- [ ] :tacos::unlock should not cancel convert-to-draft | ||
- remove :tacos::unlock in favor of convert-to-draft | ||
- deprecation phase: post a PR comment about "convert to draft instead" | ||
- [~] @buck combined summary comments | ||
- simple version: concatenate | ||
- FIXME: we need a fan-in summary | ||
- FIXME: this really should be done in a fan-in summary job | ||
- [ ] fan-in summary for the tacos_unlock workflow | ||
Comment on lines
-56
to
-58
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are these being removed? Not needed? |
||
- [x] @jim ops fixes to project & bucket permissions | ||
- https://getsentry.atlassian.net/browse/OPS-5203 | ||
- done: | ||
- [x] @ellison Tell user that merge conflicts are preventing plan/apply | ||
- [x] @ellison JIRA backlog to tf-import test-region bucket IAM | ||
- gs://sentry-test-region-terraform | ||
- https://getsentry.atlassian.net/browse/OPS-5244 | ||
- [x] @ellison clickops quickfix test-region bucket | ||
- https://gist.github.com/bukzor/ee00a6f75d4a0cc7f865c37cfa67a895 | ||
|
||
### M4 Drift Remediation | ||
|
||
|
@@ -75,17 +53,6 @@ Definition: All ops slices are subject to TACOS lock-on-drift. | |
- assignees: buck ellison neo | ||
|
||
* [ ] drift remediation | ||
|
||
- [?] @ellison phased allowlist: | ||
https://github.com/getsentry/tacos-gha/pull/119 | ||
1. [x] off | ||
2. ~[wontfix] plan-only~ | ||
3. [ ] plan-and-lock | ||
4. [x] plan-lock-apply | ||
5. [ ] drift detection | ||
- [~] @neo ensure lock conflict message links to the lock-holding PR | ||
- essential for people know when there's conflicting drift | ||
- i.e. Ensure there's a good, human-readable PR message for unlock failure | ||
- [ ] @buck raise XFailed("tacos/drift branch not created") branch? | ||
- [ ] @buck TODO: check for the opening of the drift remediation branch. | ||
- [ ] @buck TODO: anything (scenario: drift detection) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these being removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The combined messages is done.
I believe @ellisonmarks fixed the test suite.