Explicity set user.ip_address: {{auto}}
#118
Comments
|
@bitsandfoxes I'm pretty sure Unity does the right thing (the dotnet sdk that is, which would be true then for Unity, Xamarin and PowerShell. But could you please double check? |
|
|
github-project-automation
bot
moved this to Needs Discussion
in Mobile & Cross Platform SDK
|
for spans, relay populates the client.address attribute (even if no explicit auto is set): for sessions there's the ip_address attribute: |
|
Issue created for Capacitor getsentry/sentry-capacitor#819 |
Part of getsentry/team-sdks#118 This is so far inferred at relay-side, which is pretty intransparent and potentially confusing. So instead, we want to explicitly set this in the SDK. If this is set to `null` it will not be inferred (which is kind of intransparent too, but...) This is set for: * error events (as `user.ip_address`) * transactions (as `user.ip_address`) * replay events (as `user.ip_address`) * profiles (as `user.ip_address`) * sessions (as `user.ip_address`) * session aggregates: as `attr.ip_address: '{{auto}}'` * standalone spans (not by default, but added to all standalone web vitals spans we emit, as `'client.address': '{{auto}}'` attribute)
|
Current Relay behavior:
We can change the special casing for js and cocoa to a specific verion. Since INP spans also come from javascript, we can apply the same fallback behavior there, so the behavior is aligned across data types. |
|
@jjbayer What is covered by |
|
@krystofwoldrich relay currently special cases its behavior if the |
|
The Electron SDK uses |
|
@tustanivsky could you take a look how it works on the Unreal SDK? @limbonaut could you take a look how it works on the Godot SDK, in case we already added this to it? |
|
@jjbayer RN Uses platform "javascript" for JS events. |
|
Does |
|
@krystofwoldrich No, since we don't have |
Explicitly set `user.ip_address` to "{{auto}}" if `options.send_default_pii` is enabled and the dev didn't set user data explicitly (i.e. in a configuration script).
Additionally:
- Ensure the user is properly set even if `set_user()` is called before initialization.
- User data is no longer saved to disk. This is a **breaking change**.
- Another **breaking change** is `user.is_user_valid()` is replaced in favor of `user.is_empty()`.
Resolves GH-95
Related to getsentry/team-sdks#118
Description
For client side SDKs, we need to explicitly set the user's IP address to
{{auto}}, if the property was not set by the user.By default, SDKs should not set
{{auto}}and only do so ifsendDefaultPiiwas set totrueby the user.Docs: https://develop.sentry.dev/sdk/expected-features/data-handling/
See getsentry/relay#4431
Stakeholder(s)
@jjbayer
Team(s)
Mobile, Web Frontend, GDX
SDKs
SDKs
The text was updated successfully, but these errors were encountered: