Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/hooks: Prefill update info in commit msg #3489

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

joebonrichie
Copy link
Contributor

Summary

  • If the version has been changed in the package.yml as part of the commit then prefill that information in the commit header. e.g. nano: Update to 1.2.3

Test Plan

Update some pkgs, verify commit info gets prefilled.

Checklist

  • Package was built and tested against unstable

@ermo
Copy link
Contributor

ermo commented Aug 7, 2024

Given that this imports new libraries, doesn't it need to be accompanied by an update to the packaging documentation for ensuring that the user installs pyyaml?

(from what I can tell, subprocess is part of the normal py3 distribution, so doesn't need to be explicitly installed)

@joebonrichie
Copy link
Contributor Author

Normally i would agree but pyyaml needs to be installed as part of ypkg e.g. go-task bump anyway. I do wonder where the best way to check this would be?

@joebonrichie joebonrichie force-pushed the hooks-prefill-update-commit-msg branch 2 times, most recently from 3e3ec68 to 3bcf0c3 Compare August 7, 2024 19:19
@joebonrichie joebonrichie force-pushed the hooks-prefill-update-commit-msg branch from 3bcf0c3 to 785e3a4 Compare August 10, 2024 14:35
@joebonrichie joebonrichie force-pushed the hooks-prefill-update-commit-msg branch from 785e3a4 to 66a223d Compare August 10, 2024 14:50
Copy link
Member

@silkeh silkeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@silkeh silkeh merged commit c658be1 into main Aug 15, 2024
2 checks passed
@davidjharder davidjharder deleted the hooks-prefill-update-commit-msg branch August 31, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants