snowflake: OBJECT constants might rely on expressions

getsynq · Dec 20, 2023 · 8302d04 · 8302d04
1 parent ca6b5da
commit 8302d04
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/src/ast/value.rs b/src/ast/value.rs
@@ -20,6 +20,7 @@ use bigdecimal::BigDecimal;
 #[cfg(feature = "serde")]
 use serde::{Deserialize, Serialize};
 
+use crate::ast::Expr;
 #[cfg(feature = "visitor")]
 use sqlparser_derive::{Visit, VisitMut};
 
@@ -28,7 +29,7 @@ use sqlparser_derive::{Visit, VisitMut};
 #[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
 pub struct ObjectConstantKeyValue {
     pub key: String,
-    pub value: Value,
+    pub value: Box<Expr>,
 }
 
 /// Primitive SQL values such as number and string

diff --git a/src/parser/mod.rs b/src/parser/mod.rs
@@ -4955,7 +4955,7 @@ impl<'a> Parser<'a> {
                 loop {
                     let key = self.parse_literal_string()?;
                     self.expect_token(&Token::Colon)?;
-                    let value = self.parse_value()?;
+                    let value = Box::new(self.parse_expr()?);
                     fields.push(ObjectConstantKeyValue { key, value });
                     if !self.consume_token(&Token::Comma) {
                         break;

diff --git a/tests/sqlparser_snowflake.rs b/tests/sqlparser_snowflake.rs
@@ -1195,6 +1195,11 @@ fn parse_object_constants() {
     snowflake().verified_stmt("UPDATE my_table SET my_object = OBJECT_CONSTRUCT('Alberta', 'Edmonton', 'Manitoba', 'Winnipeg')");
 }
 
+#[test]
+fn parse_object_constants_expr() {
+    snowflake().verified_stmt("SELECT { 'foo': bar.baz } AS r FROM tbl AS bar");
+}
+
 #[test]
 fn parse_array_index_json_dot() {
     let stmt = snowflake().verified_only_select("SELECT src[0].order_number FROM car_sales");