Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Submission: Samba #1161

Merged
merged 14 commits into from
Jul 30, 2024
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions samba/data/samba/smb.conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the default smb.conf in the container and it seems like the only difference is the force user and force group keys. Both of which can set by environment variables. The only reason I can think of to keep this file then in the repository, is to allow advanced users to edit this file. I am not sure, maybe we can remove this file altogether and tell advanced users to modify the docker-compose.yml directly.

Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
[global]
security = user
server min protocol = SMB2

# disable printing services
load printers = no
printing = bsd
printcap name = /dev/null
disable spoolss = yes

[storage]
path = /storage
comment = Shared
valid users = @smb
browseable = yes
writable = yes
read only = no
force user = umbrel
force group = smb
28 changes: 28 additions & 0 deletions samba/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
version: '3.7'

services:
app_proxy:
environment:
APP_HOST: samba_homepage_1
APP_PORT: 80

homepage:
image: loficafe/static-web-server-samba:1.0.1@sha256:783667f052d9535bb75946ff9bc807989b041e25437ef10c30b291589d041e6e
restart: on-failure
user: "1000:1000"
volumes:
- ${APP_DATA_DIR}/data/samba/smb.conf:/public/smb.conf:ro

server:
image: dockurr/samba:4.20.1@sha256:9a57887c0be1242ee2e1381653619a656820e1aee8e271885662d04c2c367be8
restart: on-failure
environment:
USER: umbrel
PASS: ${APP_PASSWORD}
UID: 1000
GID: 1000
ports:
- '446:445'
volumes:
- ${APP_DATA_DIR}/data/samba/smb.conf:/etc/samba/smb.conf
- ${UMBREL_ROOT}/data/storage:/storage
40 changes: 40 additions & 0 deletions samba/umbrel-app.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
manifestVersion: 1
id: samba
name: Samba
tagline: Make your storage accessible using Samba
category: networking
version: "4.20.1"
port: 9445
description: >-
📂 Simplify your file sharing with Samba!

Samba is a powerful tool that makes it easy to share files across different devices on your network. It allows your Umbrel device to seamlessly share files with Windows, macOS, Linux, and more. Whether you're sharing documents, media files, or backups, Samba makes it simple and secure.


📄 Effortless File Access

Access and manage the files on your Umbrel device from any computer on your network. Say good bye to the complicated SSH access!


🖥️ Cross-Platform Compatibility

Samba works with all major operating systems, including Windows, macOS, and Linux. Share your files without worrying about compatibility issues.


🛡️ Secure and Reliable

Samba has been providing secure and stable file sharing for over 30 years. Trust it to keep your files safe and accessible.
developer: Samba
website: https://www.samba.org/
submitter: João Victor
permissions:
- STORAGE_DOWNLOADS
submission: https://github.com/getumbrel/umbrel-apps/pull/1161
repo: https://github.com/dockur/samba
support: https://github.com/dockur/samba/issues
gallery: []
releaseNotes: ""
dependencies: []
path: ""
defaultUsername: "umbrel"
deterministicPassword: true