-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Submission: Samba #1161
Merged
Merged
App Submission: Samba #1161
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
10777d9
Add Samba
joaovictor-local 68d7c59
samba: use native umbrel password generation
joaovictor-local f1916d9
samba: replace httpd with static-web-server
joaovictor-local a96e10d
samba: fix favicon and page title
joaovictor-local 3372825
samba: apply change requests
joaovictor-local 4579e99
samba: fix typo on homepage
joaovictor-local 43586bb
samba: fix smb.conf
joaovictor-local 280288e
rename default path name for storage
joaovictor-local 541476a
move samba.conf into samba directory on host
nmfretz 49524cd
Change exposed port from 445 to 446 so it does not clash with Back Th…
nmfretz 223749d
Make smb.conf read only for homepage container
nmfretz 807a98f
samba: update app description
joaovictor-local 19e618c
move public folder to containerized stactic web server
joaovictor-local f47fcfa
Add gallery images
nmfretz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
[global] | ||
security = user | ||
server min protocol = SMB2 | ||
|
||
# disable printing services | ||
load printers = no | ||
printing = bsd | ||
printcap name = /dev/null | ||
disable spoolss = yes | ||
|
||
[storage] | ||
path = /storage | ||
comment = Shared | ||
valid users = @smb | ||
browseable = yes | ||
writable = yes | ||
read only = no | ||
force user = umbrel | ||
force group = smb |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
version: '3.7' | ||
|
||
services: | ||
app_proxy: | ||
environment: | ||
APP_HOST: samba_homepage_1 | ||
APP_PORT: 80 | ||
|
||
homepage: | ||
image: loficafe/static-web-server-samba:1.0.1@sha256:783667f052d9535bb75946ff9bc807989b041e25437ef10c30b291589d041e6e | ||
restart: on-failure | ||
user: "1000:1000" | ||
volumes: | ||
- ${APP_DATA_DIR}/data/samba/smb.conf:/public/smb.conf:ro | ||
|
||
server: | ||
image: dockurr/samba:4.20.1@sha256:9a57887c0be1242ee2e1381653619a656820e1aee8e271885662d04c2c367be8 | ||
restart: on-failure | ||
joaovictor-local marked this conversation as resolved.
Show resolved
Hide resolved
|
||
environment: | ||
USER: umbrel | ||
PASS: ${APP_PASSWORD} | ||
joaovictor-local marked this conversation as resolved.
Show resolved
Hide resolved
|
||
UID: 1000 | ||
GID: 1000 | ||
ports: | ||
- '446:445' | ||
volumes: | ||
- ${APP_DATA_DIR}/data/samba/smb.conf:/etc/samba/smb.conf | ||
- ${UMBREL_ROOT}/data/storage:/storage |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
manifestVersion: 1 | ||
id: samba | ||
name: Samba | ||
tagline: Make your storage accessible using Samba | ||
category: networking | ||
version: "4.20.1" | ||
port: 9445 | ||
description: >- | ||
📂 Simplify your file sharing with Samba! | ||
|
||
Samba is a powerful tool that makes it easy to share files across different devices on your network. It allows your Umbrel device to seamlessly share files with Windows, macOS, Linux, and more. Whether you're sharing documents, media files, or backups, Samba makes it simple and secure. | ||
|
||
|
||
📄 Effortless File Access | ||
|
||
Access and manage the files on your Umbrel device from any computer on your network. Say good bye to the complicated SSH access! | ||
|
||
|
||
🖥️ Cross-Platform Compatibility | ||
|
||
Samba works with all major operating systems, including Windows, macOS, and Linux. Share your files without worrying about compatibility issues. | ||
|
||
|
||
🛡️ Secure and Reliable | ||
|
||
Samba has been providing secure and stable file sharing for over 30 years. Trust it to keep your files safe and accessible. | ||
developer: Samba | ||
website: https://www.samba.org/ | ||
submitter: João Victor | ||
joaovictor-local marked this conversation as resolved.
Show resolved
Hide resolved
|
||
permissions: | ||
- STORAGE_DOWNLOADS | ||
submission: https://github.com/getumbrel/umbrel-apps/pull/1161 | ||
repo: https://github.com/dockur/samba | ||
support: https://github.com/dockur/samba/issues | ||
gallery: [] | ||
releaseNotes: "" | ||
dependencies: [] | ||
path: "" | ||
defaultUsername: "umbrel" | ||
deterministicPassword: true |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked the default
smb.conf
in the container and it seems like the only difference is theforce user
andforce group
keys. Both of which can set by environment variables. The only reason I can think of to keep this file then in the repository, is to allow advanced users to edit this file. I am not sure, maybe we can remove this file altogether and tell advanced users to modify thedocker-compose.yml
directly.