-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add chromium browser #1888
add chromium browser #1888
Conversation
Maybe the docker-compose.yml is missing here...? |
I just did thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @maddog1110 for submitting this app. I am really looking forward to having a fully featured chromium browser installed on umbrelOS.
I have left some suggestions for improvements below:
apps/chromium-browser/icon.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Co-authored-by: Josua Frank <[email protected]>
Co-authored-by: Josua Frank <[email protected]>
Hey @maddog1110. I have gone through and finalized this submission by addressing @sharknoon's suggestions. We'll get the gallery assets together and then this can go live 🎉 I've pushed atomic commits so you can easily see the changes and understand what happened. Thanks again for the submission! |
@nmfretz look great |
|
Severity | File | Description |
---|---|---|
chromium/umbrel-app.yml |
"icon" and "gallery" needs to be empty for new app submissions: The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team. |
Legend
Symbol | Description |
---|---|
❌ | Error: This must be resolved before this PR can be merged. |
Warning: This is highly encouraged to be resolved, but is not strictly mandatory. | |
ℹ️ | Info: This is just for your information. |
Gallery assets have been prepared. Going live. Thanks again for adding Chromium @maddog1110! ![]() |
Chromium Browser App for Umbrel
A full-featured Chromium browser with secure remote access, powered by LinuxServer.io.
Features
Testing
Gallery Images