App Submission: Downtify #2177
App Submission: Downtify #2177
Conversation
There was a problem hiding this comment.
Hey @henriquesebastiao!
Nice submission! 🚀
Only have some minor points.
Lets see what @nmfretz has to say about it as well.
downtify/docker-compose.yml
Outdated
| environment: | ||
| - PUID=1000 | ||
| - PGID=1000 |
There was a problem hiding this comment.
I would set it via the user: option.
| environment: | |
| - PUID=1000 | |
| - PGID=1000 | |
| user: "1000:1000 |
There was a problem hiding this comment.
When configuring user: "1000:1000" in docker-compose.yml Downtify does not perform downloads correctly, as an alternative I adapted the docker image to run as user 1000:1000, as happens with MeTube.
More information about how this is implemented can be obtained by viewing the Dockerfile and entrypoint.sh files that build the Downtify image.
| description: >- | ||
| With Downtify you can download Spotify musics containing album art, track names, album title and other metadata about the songs. | ||
| Just copy the Spotify link, whether it's a single song, an album, etc. | ||
| As soon as your downloads are complete you will be notified! |
There was a problem hiding this comment.
Maybe you could add the legal section from your repository here as well. What do you think @nmfretz ?
There was a problem hiding this comment.
@al-lac as for the legal section, do you mean the copyright notice for the songs? I hadn't thought of that, but it really is important.
🎉 Linting finished with no errors or warnings 🎉Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store. Please review the linting results below and make any necessary changes to your submission. Linting Results
Legend
|
App Submission
Downtify
256x256 SVG icon
Gallery images
I have tested my app on: