Update to the latest simple-monerod image #2188
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colder-is-better
force-pushed
the
update_monerod_image
branch
from
0e6f18a to
6dc16cc
Compare
This image includes the ban list of suspected spy node IP addresses, provided by the Monero Research Lab. References: - monero-project/meta#1124 - sethforprivacy/simple-monerod-docker@cea9d8c
colder-is-better
force-pushed
the
update_monerod_image
branch
from
6dc16cc to
9f2c5c2
Compare
|
| Severity | File | Description |
|---|---|---|
| ℹ️ | monero/docker-compose.yml |
Mounted file/directory "/monero/torrc" doesn't exist: The volume "${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro" tries to mount the file/directory "/monero/torrc", but it is not present. This can lead to permission errors! |
| ℹ️ | monero/docker-compose.yml |
External port mapping "${APP_MONERO_P2P_PORT}:${APP_MONERO_P2P_PORT}": Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.). |
| ℹ️ | monero/docker-compose.yml |
External port mapping "${APP_MONERO_RPC_PORT}:${APP_MONERO_RPC_PORT}": Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.). |
| ℹ️ | monero/docker-compose.yml |
Potentially using unsafe user in service "server": The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000. |
monero/docker-compose.yml |
Invalid restart policy: The restart policy of the container "monerod" should be set to "on-failure". |
Legend
| Symbol | Description |
|---|---|
| ❌ | Error: This must be resolved before this PR can be merged. |
| Warning: This is highly encouraged to be resolved, but is not strictly mandatory. | |
| ℹ️ | Info: This is just for your information. |
|
Thanks for this update @colder-is-better! And thanks for linking the references, I really appreciate it. I will review and merge soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This image includes the ban list of suspected spy node IP addresses, provided by the Monero Research Lab.
References:
MRL recommendation: Ban spy node IP addresses from connecting to your node monero-project/meta#1124
sethforprivacy/simple-monerod-docker@cea9d8c