Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RTL (Core Lightning) - Add Boltz client #2217

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

jackstar12
Copy link
Contributor

Depends on: #2180

Copy link
Contributor

@nmfretz nmfretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition @jackstar12! I have left some suggested changes and comments below.

When testing both a fresh install and an app update, the new boltz container fails to start with the following error:

Using data dir: /data/.boltz
2025-02-19 01:58:17.800 [INFO ] Starting version v2.3.9-161f2ef8 compiled with go1.23.0
2025-02-19 01:58:17.801 [INFO ] Parsed config and CLI arguments: {
  "DataDir": "/data/.boltz",
  "ConfigFile": "/data/.boltz/boltz.toml",
  "LogFile": "/data/.boltz/boltz.log",
  "LogLevel": "info",
  "LogMaxSize": 5,
  "LogMaxAge": 30,
  "Network": "mainnet",
  "Boltz": {
    "URL": ""
  },
  "LND": {
    "Host": "127.0.0.1",
    "Port": 10009,
    "Macaroon": "",
    "Certificate": "",
    "DataDir": "",
    "Insecure": false
  },
  "Cln": {
    "Host": "10.21.21.96",
    "Port": 2107,
    "DataDir": "/cln/bitcoin",
    "RootCert": "/cln/bitcoin/ca.pem",
    "PrivateKey": "/cln/bitcoin/client-key.pem",
    "CertChain": "/cln/bitcoin/client.pem",
    "ServerName": "cln",
    "Client": null
  },
  "Node": "",
  "Standalone": false,
  "RPC": {
    "Host": "127.0.0.1",
    "Port": 9002,
    "RestHost": "0.0.0.0",
    "RestPort": 9003,
    "RestDisabled": false,
    "TlsCertPath": "/data/.boltz/tls.cert",
    "TlsKeyPath": "/data/.boltz/tls.key",
    "NoTls": false,
    "NoMacaroons": false,
    "AdminMacaroonPath": "/data/.boltz/macaroons/admin.macaroon",
    "ReadonlyMacaroonPath": "/data/.boltz/macaroons/readonly.macaroon"
  },
  "Database": {
    "Path": "/data/.boltz/boltz.db"
  },
  "MempoolApi": "",
  "MempoolLiquidApi": "",
  "ElectrumUrl": "",
  "ElectrumSSL": false,
  "ElectrumLiquidUrl": "",
  "ElectrumLiquidSSL": false,
  "Proxy": "",
  "Pro": false,
  "ReferralId": "boltz-client",
  "MaxZeroConfAmount": null,
  "AutoConsolidateThreshold": null,
  "Help": {
    "ShowHelp": false,
    "ShowVersion": false
  }
}

2025-02-19 01:58:17.801 [INFO ] Opening database: /data/.boltz/boltz.db
2025-02-19 01:58:17.805 [INFO ] database already at latest schema version: 14
2025-02-19 01:58:17.806 [INFO ] Loaded TLS certificate and key
2025-02-19 01:58:17.806 [INFO ] Enabling Macaroon authentication
2025-02-19 01:58:17.808 [INFO ] Starting RPC server on: 127.0.0.1:9002
2025-02-19 01:58:17.808 [INFO ] Starting REST cfg on: 0.0.0.0:9003
2025-02-19 01:58:17.818 [FATAL] Could not start Boltz server: rpc error: code = Unavailable desc = connection error: desc = "error reading server preface: http2: frame too large"

@jackstar12
Copy link
Contributor Author

When testing both a fresh install and an app update, the new boltz container fails to start with the following error:

@nmfretz did you have your clns grpc port exposed (pr mentioned above)?

Copy link

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ core-lightning-rtl/docker-compose.yml Potentially using unsafe user in service "web":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
ℹ️ core-lightning-rtl/docker-compose.yml Potentially using unsafe user in service "boltz":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor

nmfretz commented Feb 24, 2025

@nmfretz did you have your clns grpc port exposed (pr mentioned above)?

I had thought so, since I was testing both this PR and #2180 together. But I was clearly doing something silly because everything is working fine on fresh install and app update now.

Thanks again for this addition. I've cleaned up the bind mount directories slightly and have added a notice to the release notes instructing users to upgrade their CLN app for compatibility. Going live ⚡️

@nmfretz nmfretz changed the title Add boltz-client to core-lightning-rtl Update RTL (Core Lightning) - Add Boltz client Feb 24, 2025
@nmfretz nmfretz merged commit b76bfa5 into getumbrel:master Feb 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants