-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Lightning Node to 0.18.5-beta #2220
Conversation
|
Severity | File | Description |
---|---|---|
ℹ️ | lightning/docker-compose.yml |
Mounted file/directory "/lightning/torrc" doesn't exist: The volume "${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro" tries to mount the file/directory "/lightning/torrc", but it is not present. This can lead to permission errors! |
ℹ️ | lightning/docker-compose.yml |
External port mapping "$APP_LIGHTNING_NODE_PORT:$APP_LIGHTNING_NODE_PORT": Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.). |
ℹ️ | lightning/docker-compose.yml |
External port mapping "$APP_LIGHTNING_NODE_REST_PORT:$APP_LIGHTNING_NODE_REST_PORT": Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.). |
ℹ️ | lightning/docker-compose.yml |
External port mapping "$APP_LIGHTNING_NODE_GRPC_PORT:$APP_LIGHTNING_NODE_GRPC_PORT": Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.). |
ℹ️ | lightning/docker-compose.yml |
Potentially using unsafe user in service "app": The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000. |
lightning/docker-compose.yml |
Invalid restart policy: The restart policy of the container "lnd" should be set to "on-failure". |
Legend
Symbol | Description |
---|---|
❌ | Error: This must be resolved before this PR can be merged. |
Warning: This is highly encouraged to be resolved, but is not strictly mandatory. | |
ℹ️ | Info: This is just for your information. |
Please be quick with this version update, there are critical security bugs in the latest release! |
If anyone finds any compatibility issues with connected apps, please ping me directly @nmfretz |
Hey @jkuchar, I've completed testing and this going live! |
Pending compatibility testing with major apps in the ecosystem.
TODO: check if
-deprecatedrpc=warnings
can be now be removed from the Bitcoin Node apphttps://github.com/lightningnetwork/lnd/blob/0-18-4-branch/docs/release-notes/release-notes-0.18.4.md#functional-enhancements
This update is holding up #2184