Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lightning Node to 0.18.5-beta #2220

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Conversation

nmfretz
Copy link
Contributor

@nmfretz nmfretz commented Feb 18, 2025

Pending compatibility testing with major apps in the ecosystem.

TODO: check if -deprecatedrpc=warnings can be now be removed from the Bitcoin Node app
https://github.com/lightningnetwork/lnd/blob/0-18-4-branch/docs/release-notes/release-notes-0.18.4.md#functional-enhancements

This update is holding up #2184

Copy link

⚠️   Linting finished with 1 warning   ⚠️

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ lightning/docker-compose.yml Mounted file/directory "/lightning/torrc" doesn't exist:
The volume "${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro" tries to mount the file/directory "/lightning/torrc", but it is not present. This can lead to permission errors!
ℹ️ lightning/docker-compose.yml External port mapping "$APP_LIGHTNING_NODE_PORT:$APP_LIGHTNING_NODE_PORT":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ lightning/docker-compose.yml External port mapping "$APP_LIGHTNING_NODE_REST_PORT:$APP_LIGHTNING_NODE_REST_PORT":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ lightning/docker-compose.yml External port mapping "$APP_LIGHTNING_NODE_GRPC_PORT:$APP_LIGHTNING_NODE_GRPC_PORT":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ lightning/docker-compose.yml Potentially using unsafe user in service "app":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
⚠️ lightning/docker-compose.yml Invalid restart policy:
The restart policy of the container "lnd" should be set to "on-failure".

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@jkuchar
Copy link

jkuchar commented Feb 18, 2025

Please be quick with this version update, there are critical security bugs in the latest release!

@nmfretz
Copy link
Contributor Author

nmfretz commented Feb 19, 2025

  • Tested fresh install and app update on both arm64 and x86
  • Tested compatibility with other major apps on the umbrelOS app store.
  • Added a note to the 28.1 Bitcoin Node app update to update their Lightning Node app to this latest version available in the app store to ensure compatibility. Update Bitcoin Node to v28.1 #2219

If anyone finds any compatibility issues with connected apps, please ping me directly @nmfretz

@nmfretz
Copy link
Contributor Author

nmfretz commented Feb 19, 2025

Please be quick with this version update, there are critical security bugs in the latest release!

Hey @jkuchar, I've completed testing and this going live!
Just to be clear though, are you talking about security bug fixes in LND? I don't think there are any it 0.18.4-beta and 0.18.5-beta, which is what this release includes. But perhaps there indeed are and haven't been disclosed.

@nmfretz nmfretz merged commit 44b5989 into master Feb 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants