Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/filter cleanup #58

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Patch/filter cleanup #58

merged 3 commits into from
Nov 28, 2023

Conversation

anngvu
Copy link
Contributor

@anngvu anngvu commented Nov 21, 2023

@inodb main reviewer, @cconrad8 for awareness

  • Resolve Gender filter (most of data provided uses Sex, and the data model uses Sex). There are a couple places where this is is NA because it was not originally provided (because it was so obvious, or we're still waiting on final clinical data), but these should be relatively to confirm in the publication or get directly pretty soon.
  • A couple of change ideas from add links to projects, restructure table #57 that made sense to include here (I think that PR included 4-5 conceptual changes, so for the remaining 2-3 ideas, potentially @cconrad8 could followup with a couple of smaller stabs at them)
    • Remove organ and country filters
    • Correct yet another HTAN id attribute

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 8:13pm

@cconrad8
Copy link
Contributor

@anngvu any idea why records wouldn't be displayed here?

@anngvu anngvu marked this pull request as draft November 21, 2023 16:21
@anngvu
Copy link
Contributor Author

anngvu commented Nov 21, 2023

@cconrad8 Moved this to draft to debug. Works on local dev after clearing cache, so I think this is some nuanced Vercel issue.
image

@onursumer
Copy link
Collaborator

Seems like the processed_syn_data.json is missing on the vercel instance

image

@anngvu
Copy link
Contributor Author

anngvu commented Nov 21, 2023

Is it not running gunzip properly?

@cconrad8
Copy link
Contributor

cconrad8 commented Nov 21, 2023

@anngvu Oh wait i think it's good now...I think I might have messed something up when I was doing stuff last week
the build command was set to next build

this is the picture of what I just switched it off to and it works:

image

@anngvu
Copy link
Contributor Author

anngvu commented Nov 21, 2023

@cconrad8 Great, glad you remembered and figured it out! 👍🏼 😅 Really thought it was a weird caching issue.

@anngvu anngvu marked this pull request as ready for review November 21, 2023 21:42
This was linked to issues Nov 22, 2023
@anngvu anngvu merged commit 080b6fd into develop Nov 28, 2023
2 checks passed
@cconrad8 cconrad8 deleted the patch/filter-cleanup branch November 28, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix filtering for Gender/Sex Remove organ filter
3 participants