Snatch bind groups associated with destroyed textures and buffers #5136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nical
changed the title
nical
force-pushed
the
snatch-bindgroup
branch
from
4cda6f0 to
9db9da7
Compare
|
Restarted CI; looks like the jobs from the last run were manually cancelled. 🤔 |
|
They weren't manually canceled, they're timing out. |
|
Documenting seems to be taking a long time sometimes |
Are we running into the issue motivating #5006 again, perhaps? |
|
Yeah this seems to have re-aggravated the problem. I can reproduce it locally (taking about 2.5min on my M1, so 6min on a virtualized machine doesn't sound crazy. |
|
I'm going to up the timeout to unblock us, but this needs a separate investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Rebased on top of #5131
Description
Addresses the BindGroup part of #5079.
Checklist
cargo fmt.cargo clippy.cargo xtask testto run tests.