examples: Call pre_present_notify before presenting #7074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
winit-pre-present-notify
branch
from
81cadad to
5049730
Compare
According to winit docs, pre_present_notify() should be called right before calling present(). This actually prevents some issues on Wayland, like freezing the whole application when the window is not visible (ask me how I know).
kjarosh
force-pushed
the
winit-pre-present-notify
branch
from
5049730 to
7015a2a
Compare
nical
approved these changes
Feb 10, 2025
davnotdev
pushed a commit
to davnotdev/wgpu
that referenced
this pull request
Mar 4, 2025
According to winit docs, pre_present_notify() should be called right before calling present(). This actually prevents some issues on Wayland, like freezing the whole application when the window is not visible (ask me how I know).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to winit docs,
pre_present_notify()should be called right before callingpresent().This actually prevents some issues on Wayland, like freezing the whole application when the window is not visible (ask me how I know).
See ruffle-rs/ruffle#19456
Testing
Tested by running examples on Wayland. It's enough to add a
dbg!inabout_to_waitto observe the difference. Without this patch nothing's logged when the window is not visible, because the event loop is blocked due topresent()not returning.Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.