[naga] Retain unnamed constants' and overrides' types during compaction. #7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
added
type: bug
jimblandy
force-pushed
the
naga-compact-retain-unnamed-constant-types
branch
2 times, most recently
from
bea7832 to
13b01f7
Compare
Ensure that unnamed constants' types are retained, even when the constants are used only by global expressions. Add a test case. The old code marked all named constants as used; then processed function bodies; and then marked the types of all used constants as used. This ensured that, as long as a constant was used by a function, its type would be retained, but didn't address the case where a constant is used only by a global expression.
Ensure that unnamed overrides' types are retained, even when the overrides are used only by global expressions. Add a test case. Fixes gfx-rs#7072.
jimblandy
force-pushed
the
naga-compact-retain-unnamed-constant-types
branch
from
13b01f7 to
194b682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that unnamed constants' types are retained, even when the
constants are used only by global expressions. Add a test case.
Similarly for overrides.
The old code marked all named constants as used; then processed
function bodies; and then marked the types of all used constants as
used. This ensured that, as long as a constant was used by a function,
its type would be retained, but didn't address the case where a
constant is used only by a global expression.
Fixes #7072.