-
Notifications
You must be signed in to change notification settings - Fork 11.5k
vulkan: Fix missing cmake logic for dot product extension #12721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am seeing an emerging trend in the calls to execute_process
to test-compile shaders. I don't expect it in this PR, but just noting that we should roll those checks into a macro/function to clean this up a bit and make it easier for adding new feature detection.
I am happy to make this change once I clean up some of my existing PRs 🙂
This would be great. There will surely be more features in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This is a missing interaction between #12135 and #12272