Skip to content

vulkan: Fix missing cmake logic for dot product extension #12721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

jeffbolznv
Copy link
Collaborator

This is a missing interaction between #12135 and #12272

@jeffbolznv jeffbolznv requested review from 0cc4m and bandoti April 2, 2025 15:26
@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Apr 2, 2025
Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Copy link
Collaborator

@bandoti bandoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing an emerging trend in the calls to execute_process to test-compile shaders. I don't expect it in this PR, but just noting that we should roll those checks into a macro/function to clean this up a bit and make it easier for adding new feature detection.

I am happy to make this change once I clean up some of my existing PRs 🙂

@jeffbolznv
Copy link
Collaborator Author

I am seeing an emerging trend in the calls to execute_process to test-compile shaders. I don't expect it in this PR, but just noting that we should roll those checks into a macro/function to clean this up a bit and make it easier for adding new feature detection.

I am happy to make this change once I clean up some of my existing PRs 🙂

This would be great. There will surely be more features in the future.

Copy link
Collaborator

@bandoti bandoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jeffbolznv jeffbolznv merged commit 1c05999 into ggml-org:master Apr 3, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants