Useless parentheses around expressions should be removed

src/main/java/org/ggp/base/apps/kiosk/games/BlockerCanvas.java

@@ -28,8 +28,8 @@ protected void renderCellBackground(Graphics g, int xCell, int yCell) {
         int width = g.getClipBounds().width;
         int height = g.getClipBounds().height;
 
-        boolean isBlue = (yCell == 0) || (yCell == 5);
-        boolean isBlack = ((xCell == 0) || (xCell == 5)) && !isBlue;
+        boolean isBlue = yCell == 0 || yCell == 5;
+        boolean isBlack = (xCell == 0 || xCell == 5) && !isBlue;
 
         if(isBlue) {
             CommonGraphics.drawBubbles(g, xCell*11+yCell);

src/main/java/org/ggp/base/apps/server/states/StatesPanel.java

@@ -54,7 +54,7 @@ public void observe(Event event) {
             // moved off into a new thread
             int stepNum = stepCount;
             stepCount++;
-            boolean atEnd = (tabs.getSelectedIndex() == tabs.getTabCount()-1);
+            boolean atEnd = tabs.getSelectedIndex() == tabs.getTabCount()-1;
 
             for(int i = tabs.getTabCount(); i < stepNum; i++)
                 tabs.add(new Integer(i+1).toString(), new JPanel());

src/main/java/org/ggp/base/player/gamer/statemachine/random/RandomGamer.java

@@ -34,7 +34,7 @@ public Move stateMachineSelectMove(long timeout) throws TransitionDefinitionExce
         long start = System.currentTimeMillis();
 
         List<Move> moves = getStateMachine().getLegalMoves(getCurrentState(), getRole());
-        Move selection = (moves.get(new Random().nextInt(moves.size())));
+        Move selection = moves.get(new Random().nextInt(moves.size()));
 
         long stop = System.currentTimeMillis();
 

src/main/java/org/ggp/base/player/gamer/statemachine/sample/SampleSearchLightGamer.java

@@ -73,7 +73,7 @@ public Move stateMachineSelectMove(long timeout) throws TransitionDefinitionExce
         long finishBy = timeout - 1000;
 
         List<Move> moves = theMachine.getLegalMoves(getCurrentState(), getRole());
-        Move selection = (moves.get(theRandom.nextInt(moves.size())));
+        Move selection = moves.get(theRandom.nextInt(moves.size()));
 
         // Shuffle the moves into a random order, so that when we find the first
         // move that doesn't give our opponent a forced win, we aren't always choosing

src/main/java/org/ggp/base/util/propnet/architecture/PropNet.java

@@ -141,14 +141,14 @@ private Map<Proposition, Proposition> makeLegalInputMap() {
         // Create a mapping from Body->Input.
         Map<List<GdlTerm>, Proposition> inputPropsByBody = new HashMap<List<GdlTerm>, Proposition>();
         for(Proposition inputProp : inputPropositions.values()) {
-            List<GdlTerm> inputPropBody = (inputProp.getName()).getBody();
+            List<GdlTerm> inputPropBody = inputProp.getName().getBody();
             inputPropsByBody.put(inputPropBody, inputProp);
         }
         // Use that mapping to map Input->Legal and Legal->Input
         // based on having the same Body proposition.
         for(Set<Proposition> legalProps : legalPropositions.values()) {
             for(Proposition legalProp : legalProps) {
-                List<GdlTerm> legalPropBody = (legalProp.getName()).getBody();
+                List<GdlTerm> legalPropBody = legalProp.getName().getBody();
                 if (inputPropsByBody.containsKey(legalPropBody)) {
                     Proposition inputProp = inputPropsByBody.get(legalPropBody);
                     legalInputMap.put(inputProp, legalProp);

src/main/java/org/ggp/base/util/prover/aima/AimaProver.java

@@ -153,7 +153,7 @@ private void askOr(GdlOr or, LinkedList<GdlLiteral> goals, KnowledgeBase context
             isConstant &= isConstantRet.value;
             goals.removeFirst();
 
-            if (askOne && (results.size() > 0))
+            if (askOne && results.size() > 0)
             {
                 break;
             }
@@ -171,7 +171,7 @@ private void askSentence(GdlSentence sentence, LinkedList<GdlLiteral> goals, Kno
         {
             ask(goals, context, theta.compose(thetaPrime), cache, renamer, askOne, results, recursionHandler, isConstantRet);
             isConstant &= isConstantRet.value;
-            if (askOne && (results.size() > 0))
+            if (askOne && results.size() > 0)
             {
                 break;
             }
@@ -275,7 +275,7 @@ private Collection<Substitution> findSentenceResults(GdlSentence sentence,
         }
 
         List<Substitution> cachedResults = fixedAnswerCache.get(sentence, varRenamedSentence);
-        isConstantRet.value = (cachedResults != null);
+        isConstantRet.value = cachedResults != null;
         if (cachedResults == null) {
             cachedResults = cache.get(sentence, varRenamedSentence);
         }

src/main/java/org/ggp/base/util/prover/aima/substitution/Substitution.java

@@ -35,7 +35,7 @@ public boolean contains(GdlVariable variable)
     @Override
     public boolean equals(Object o)
     {
-        if ((o != null) && (o instanceof Substitution))
+        if (o != null && o instanceof Substitution)
         {
             Substitution substitution = (Substitution) o;
             return substitution.contents.equals(contents);

src/main/java/org/ggp/base/util/prover/aima/unifier/Unifier.java

@@ -25,7 +25,7 @@ private static boolean unifyTerm(GdlTerm x, GdlTerm y, Substitution theta)
     {
         if(x.equals(y))
             return true;
-        if ((x instanceof GdlConstant) && (y instanceof GdlConstant))
+        if (x instanceof GdlConstant && y instanceof GdlConstant)
         {
             if (!x.equals(y))
             {
@@ -42,7 +42,7 @@ else if (y instanceof GdlVariable)
             if (!unifyVariable((GdlVariable) y, x, theta))
                 return false;
         }
-        else if ((x instanceof GdlFunction) && (y instanceof GdlFunction))
+        else if (x instanceof GdlFunction && y instanceof GdlFunction)
         {
             GdlFunction xFunction = (GdlFunction) x;
             GdlFunction yFunction = (GdlFunction) y;
@@ -70,7 +70,7 @@ private static boolean unifyVariable(GdlVariable var, GdlTerm x, Substitution th
         {
             return unifyTerm(theta.get(var), x, theta);
         }
-        else if ((x instanceof GdlVariable) && theta.contains((GdlVariable) x))
+        else if (x instanceof GdlVariable && theta.contains((GdlVariable) x))
         {
             return unifyTerm(var, theta.get((GdlVariable) x), theta);
         }

src/main/java/org/ggp/base/util/statemachine/MachineState.java

@@ -56,7 +56,7 @@ public String toString()
     @Override
     public boolean equals(Object o)
     {
-        if ((o != null) && (o instanceof MachineState))
+        if (o != null && o instanceof MachineState)
         {
             MachineState state = (MachineState) o;
             return state.getContents().equals(getContents());

src/main/java/org/ggp/base/util/statemachine/Move.java

@@ -35,7 +35,7 @@ public static Move create(String contents) {
     @Override
     public boolean equals(Object o)
     {
-        if ((o != null) && (o instanceof Move)) {
+        if (o != null && o instanceof Move) {
             Move move = (Move) o;
             return move.contents.equals(contents);
         }

src/main/java/org/ggp/base/util/statemachine/Role.java

@@ -33,7 +33,7 @@ public static Role create(String name) {
     @Override
     public boolean equals(Object o)
     {
-        if ((o != null) && (o instanceof Role))
+        if (o != null && o instanceof Role)
         {
             Role role = (Role) o;
             return role.name.equals(name);