[kernel] Consolidate reboot, shutdown and poweroff into single program #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How are hard links done on Fat? |
They're not. For FAT, the files have to be copied multiple times. For the smallest image, 360k, we are currently only copying shutdown, instead of all three, just for this reason. But that shouldn't be a big deal not having poweroff or reboot commands on 360k. Actually, I suppose we could add an option to shutdown/power/reboot to do any of the three, (-s/-p/-r) which could help. The current executable is 1280 bytes, so adding more code won't take away any space. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines three previously separate programs into
shutdown, then uses hard links to createrebootandpoweroff, reducing disk space while increasing functionality.The functionality of these programs remains mostly the same, except that
poweroffnow also tries to unmount all mounted filesystems before powering down the system. Combining these almost-identical programs saves about 3-4k disk space.Rewrites sys_reboot for some simplification, the two magic numbers passed as first arguments are now ignored, and previously unused options are removed.