Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: rm -f -> $(RM) #2020

Closed
wants to merge 1 commit into from

Conversation

marcin-laszewski
Copy link
Contributor

Simple makefile upgrade: rm -f -> $(RM)

@ghaerr
Copy link
Owner

ghaerr commented Sep 16, 2024

I'm not sure if this change actually helps, or instead possibly introduces more risk, into the ELKS build process. The make RM variable is not required to be defined by POSIX, and is not defined in our repo. It is entirely unused, except for I notice within the libc/ build. So a portion of the repo is already dependent on it, although that could be easily remedied by defining the RM variable in libc/Makefile.

On the other hand, GNU Make does define the variable by default to rm -f. For systems not running GNU make, the variable could be defined elkscmd/Makefile.defs, which would eliminate the risk for elkscmd/*/Makefiles.

Have you tested a full development system rebuild, and on which hosts? In particular I would be hesitant to change this in tools/Makefile. This change would also trigger half-hour automated CI rebuilds for the entire development toolchain.

@ghaerr
Copy link
Owner

ghaerr commented Sep 20, 2024

Completed via #2028.

@ghaerr ghaerr closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants