[boot] Fix bad MBR partition generated by setboot #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects improper end cylinder number and partition size for hd32mbr-minix.img and hd32mbr-fat.img images. This resulted in an extra cylinder being used for the partition as well as calculating the partition size incorrectly, which would result in writing off the end of the partition, a major bug.
Also fixes
fdiskto accept only the correct start and end cylinder numbers, courtesy of @Mellvik's fix Mellvik/TLVC#93.Here's the corrected setboot (and fdisk) output for the HD32 images with CHS 63/16/63. Note the correct 32MB disk size is 63441 sectors (instead of the previous 63504):
