Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Create 64M MBR HD image with 'make images' #2133

Merged
merged 2 commits into from
Dec 14, 2024
Merged

[build] Create 64M MBR HD image with 'make images' #2133

merged 2 commits into from
Dec 14, 2024

Conversation

ghaerr
Copy link
Owner

@ghaerr ghaerr commented Dec 14, 2024

Adds hd64mbr-minix.img to build.

Requested by @rafael2k. Not tested on real hardware, only on QEMU.

@ghaerr ghaerr merged commit 80e2c75 into master Dec 14, 2024
1 check passed
@ghaerr ghaerr deleted the hd64mbr branch December 14, 2024 03:46
@rafael2k
Copy link
Contributor

Thanks! Will test on real hardware.

@rafael2k
Copy link
Contributor

rafael2k commented Dec 16, 2024

I think there is a problem here. I'm not sure how the partition table is created, but it has the same size of the 32M image, instead of the 64M one.

@ghaerr
Copy link
Owner Author

ghaerr commented Dec 16, 2024

I'm not sure how the partition table is created, but it has the same size of the 32M image, instead of the 64M one.

Thanks for testing! Let me look into this, I ran into some issues while creating this and thought it was a correct, but I think you're right. Are you getting the partition information from fdisk, which is showing the same 32M size for both?

@rafael2k
Copy link
Contributor

I'm not sure how the partition table is created, but it has the same size of the 32M image, instead of the 64M one.

Thanks for testing! Let me look into this, I ran into some issues while creating this and thought it was a correct, but I think you're right. Are you getting the partition information from fdisk, which is showing the same 32M size for both?

Yes, getting from fdisk.

@ghaerr
Copy link
Owner Author

ghaerr commented Dec 16, 2024

Ok, sorry. My original 64M image wouldn't boot from MBR, and I thought I fixed it. Now I know why - setboot isn't changing the MBR properly. I'll post a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants