switch to Qt5. #17
Open
switch to Qt5. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also note that the Qt Script module is not actively developed and is provided for Qt4 compatibility only. I could look at replacing it with QJSEngine as another PR. |
regenerate includes withc include-what-you-use. fix clazy warning function-args-by-ref. suppress compiler warnings about function parameters.
|
I have built the Qt executable on windows 10 with Qt 5.12.10. |
The include-what-you-use Qt mapping files aren't perfect. Perfer to use includes as documented by Qt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal set of changes to get working with Qt5. It may no longer work with Qt4.
The change in the arguments for the class HP15C constructor is required to avoid a segmentation fault on ubuntu focal (Qt 5.12.8).
Further changes to HP15C.pro are possible if there is interest (delete INCLUDEPATH, DEPENDPATH)Done.Please let me know where you want to go with this.