Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(telemetry): send events on trailing edge of the frequency #2139

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix(telemetry): send events on trailing edge of the frequency #2139

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c43f83f
fix(telemetry): send events on trailing edge of the frequency
smalluban Dec 11, 2024
cd78163
Extract Date.now()
smalluban Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/background/telemetry/metrics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,16 @@ export default class Metrics {
_timeToExpired(type, frequency) {
if (frequency === 'all') return 0;

const last = this.storage[`${type}_${frequency}`] || 0;
const key = `${type}_${frequency}`;

// Protect against calling events immediately after install for all frequencies
// They should trigger on the trailing edge of the frequency
if (!this.storage[key]) {
this.storage[key] = Date.now();
philipp-classen marked this conversation as resolved.
Show resolved Hide resolved
this.saveStorage(this.storage);
}

const last = this.storage[key];
const frequency_ago = Date.now() - FREQUENCIES[frequency];

return last ? last - frequency_ago : 0;
Expand Down
Loading